Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6)

Issue 1477041: PR7247: Extension to ignore global templates with same name as member (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by Jeffrey Yasskin
Modified:
9 years, 5 months ago
Reviewers:
chandlerc, Jeffrey Yasskin (google), cfe-commits
Base URL:
https://llvm.org/svn/llvm-project/cfe/trunk/
Visibility:
Public.

Description

Downgrades the error to a warning in: template<typename T> struct set{}; struct Value { template<typename T> void set(T value) { } }; void foo() { Value v; v.set<double>(3.2); }

Patch Set 1 #

Total comments: 2

Patch Set 2 : Improve manual #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -2 lines) Patch
M docs/UsersManual.html View 1 1 chunk +24 lines, -0 lines 0 comments Download
M include/clang/Basic/DiagnosticGroups.td View 1 chunk +1 line, -0 lines 0 comments Download
M include/clang/Basic/DiagnosticSemaKinds.td View 1 chunk +3 lines, -0 lines 0 comments Download
M lib/Sema/SemaTemplate.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
A test/CXX/basic/basic.lookup/basic.lookup.classref/p1.cpp View 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Jeffrey Yasskin
I couldn't find a way to use this error in SFINAE, so I didn't keep ...
9 years, 5 months ago (2010-06-02 18:19:35 UTC) #1
chandlerc
LGTM http://codereview.appspot.com/1477041/diff/1/5 File docs/UsersManual.html (right): http://codereview.appspot.com/1477041/diff/1/5#newcode408 docs/UsersManual.html:408: extension Clang downgrades it to a warning.</p> Might ...
9 years, 5 months ago (2010-06-02 20:37:01 UTC) #2
Jeffrey Yasskin (google)
http://codereview.appspot.com/1477041/diff/1/5 File docs/UsersManual.html (right): http://codereview.appspot.com/1477041/diff/1/5#newcode408 docs/UsersManual.html:408: extension Clang downgrades it to a warning.</p> On 2010/06/02 ...
9 years, 5 months ago (2010-06-02 20:41:25 UTC) #3
dgregor_apple.com
9 years, 5 months ago (2010-06-04 22:44:16 UTC) #4
On Jun 2, 2010, at 1:41 PM, jyasskin@google.com wrote:

> 
> http://codereview.appspot.com/1477041/diff/1/5
> File docs/UsersManual.html (right):
> 
> http://codereview.appspot.com/1477041/diff/1/5#newcode408
> docs/UsersManual.html:408: extension Clang downgrades it to a
> warning.</p>
> On 2010/06/02 20:37:03, chandlerc wrote:
>> Might be nice to include a motivating example?
> 
> You mean the traits one that's hard to work around? The simple
> motivating example is above, and I can't find one that actually
> justifies the warning.
> 
> http://codereview.appspot.com/1477041/show

Patch looks good, thanks!

	- Doug
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b