Issue 14737043: Fix attributes being converted when it wasn't neccessary.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14737043: Fix attributes being converted when it wasn't neccessary. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by Geoff Lang

Modified:
13 years ago

Reviewers:
Shannon Woods, Jamie Madill

CC:
angleproject-review_googlegroups.com

Base URL:
https://code.google.com/p/angleproject/@master

Visibility:
Public.

More Reviews

Description

Fix attributes being converted when it wasn't neccessary. ANGLEBUG=485

Patch Set 1 #

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/libGLESv2/renderer/VertexBuffer9.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Jamie Madill

On 2013/10/16 04:22:11, Geoff Lang wrote: > PTAL LGTM, we should also fix this in ...

13 years ago (2013-10-16 14:58:11 UTC) #2

Shannon Woods

On 2013/10/16 14:58:11, Jamie Madill wrote: > On 2013/10/16 04:22:11, Geoff Lang wrote: > > ...

13 years ago (2013-10-16 17:12:42 UTC) #3

Geoff Lang

13 years ago (2013-10-16 17:23:12 UTC) #4

On 2013/10/16 17:12:42, Shannon Woods wrote:
> On 2013/10/16 14:58:11, Jamie Madill wrote:
> > On 2013/10/16 04:22:11, Geoff Lang wrote:
> > > PTAL
> > 
> > LGTM, we should also fix this in es3proto if necessary.
> 
> LGTM.

Landed at 9e30c6bf5091344a3426b66cdf79b9ca679b9d1d.

Expand All Messages | Collapse All Messages