Issue 14715043: Add new files to vs translator project and update version.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14715043: Add new files to vs translator project and update version. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by Zhenyao Mo

Modified:
10 years, 6 months ago

Reviewers:
Jamie Madill

CC:
angleproject-review_googlegroups.com

Base URL:
https://chromium.googlesource.com/external/angle.git@master

Visibility:
Public.

More Reviews

Description

Add new files to vs translator project and update version. BUG= TEST=build fine on windows R=jmadill@chromium.org Committed: https://code.google.com/p/angleproject/source/detail?r=b992a7d

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -1 line)			Patch
M	src/common/version.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/translator.vcxproj	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/compiler/translator.vcxproj.filters	View	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Jamie Madill

On 2013/10/15 20:10:39, Zhenyao Mo wrote: > Jamie, please take a look LGTM!

10 years, 6 months ago (2013-10-15 20:14:44 UTC) #2

Zhenyao Mo

10 years, 6 months ago (2013-10-15 22:04:30 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as rb992a7d (presubmit successful).

Expand All Messages | Collapse All Messages