Issue 14702044: Rename ParseHelper.cpp/h to ParseContext.cpp/h.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14702044: Rename ParseHelper.cpp/h to ParseContext.cpp/h. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by Jamie Madill

Modified:
10 years, 6 months ago

Reviewers:
Geoff Lang, Shannon Woods

CC:
angleproject-review_googlegroups.com, Alok Priyadarshi

Base URL:
https://code.google.com/p/angleproject/@master

Visibility:
Public.

More Reviews

Description

Rename ParseHelper.cpp/h to ParseContext.cpp/h. BUG= ANGLEBUG=484 R=geofflang@chromium.org, shannonwoods@chromium.org Committed: https://code.google.com/p/angleproject/source/detail?r=5625f65

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+24 lines, -1760 lines)			Patch
src/build_angle.gypi	View	1 chunk	+2 lines, -2 lines	0 comments	Download
src/compiler/Compiler.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
src/compiler/DetectDiscontinuity.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
src/compiler/OutputGLSLBase.h	View	1 chunk	+1 line, -1 line	0 comments	Download
src/compiler/OutputHLSL.h	View	1 chunk	+1 line, -1 line	0 comments	Download
src/compiler/ParseContext.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
src/compiler/ParseContext.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
src/compiler/ParseHelper.h	View	1 chunk	+0 lines, -134 lines	0 comments	Download
src/compiler/ParseHelper.cpp	View	1 chunk	+0 lines, -1602 lines	0 comments	Download
src/compiler/SearchSymbol.h	View	1 chunk	+1 line, -1 line	0 comments	Download
src/compiler/UnfoldShortCircuit.h	View	1 chunk	+1 line, -1 line	0 comments	Download
src/compiler/ValidateLimitations.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
src/compiler/debug.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
src/compiler/glslang.l	View	1 chunk	+1 line, -1 line	0 comments	Download
src/compiler/glslang.y	View	1 chunk	+1 line, -1 line	0 comments	Download
src/compiler/glslang_lex.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
src/compiler/glslang_tab.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
src/compiler/parseConst.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
src/compiler/timing/RestrictFragmentShaderTiming.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
src/compiler/translator.vcxproj	View	2 chunks	+2 lines, -2 lines	0 comments	Download
src/compiler/translator.vcxproj.filters	View	4 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Geoff Lang

On 2013/10/15 18:18:57, Jamie Madill wrote: > PTAL! LGTM.

10 years, 6 months ago (2013-10-15 18:21:43 UTC) #2

Shannon Woods

On 2013/10/15 18:21:43, Geoff Lang wrote: > On 2013/10/15 18:18:57, Jamie Madill wrote: > > ...

10 years, 6 months ago (2013-10-15 22:25:36 UTC) #3

Jamie Madill

10 years, 6 months ago (2013-10-16 19:01:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r5625f65 (presubmit successful).

Expand All Messages | Collapse All Messages