Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(2862)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
146920043
: runtime: trace
Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by
dvyukov
Modified:
9 years, 4 months ago
Reviewers:
Visibility:
Public.
Description
runtime: trace
Patch Set 1
#
Patch Set 2 : diff -r 932fe22207465e6c4bcdae29f5c519ba069f8927 https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 3 : diff -r 932fe22207465e6c4bcdae29f5c519ba069f8927 https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 4 : diff -r 4c2e269181ea0e5cd8694c34dbfa7e360564f602 https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 5 : diff -r 4c2e269181ea0e5cd8694c34dbfa7e360564f602 https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 6 : diff -r 4c2e269181ea0e5cd8694c34dbfa7e360564f602 https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 7 : diff -r 9b457baf611b2868591c5f00ce842bdecc3d2bfa https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 8 : diff -r a46889342ac8be03d97b359fee949438c434528d https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 9 : diff -r 3042795874453efa7be0a082f3f85118b9d06432 https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 10 : diff -r 3042795874453efa7be0a082f3f85118b9d06432 https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 11 : diff -r be3fe3a1120009c4d0b9b5d497b0c8d274177292 https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 12 : diff -r 442fb01a3731b772e7e6f73b0edc4de2d81e4efc https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 13 : diff -r 0bee9108569fcc884463faa457ac4cad7776d780 https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 14 : diff -r 7d6cfbf209706dca446a55215c6b517194806638 https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 15 : diff -r e1e2e3c3cdb0be787fc6e1e60a0074e7de93f71f https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 16 : diff -r e1e2e3c3cdb0be787fc6e1e60a0074e7de93f71f https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 17 : diff -r 14e0f632a0b4d4820aea053090338d40c0068730 https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 18 : diff -r 3d68989bd1ea4f9d3cc7b37433522e7d3255a280 https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 19 : diff -r 5702295ce1eaa3a6c0699c3abec5893de889b2ed https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 20 : diff -r d053a9fe2d0153e961e3767dcc6896eeec658af7 https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 21 : diff -r d053a9fe2d0153e961e3767dcc6896eeec658af7 https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 22 : diff -r 493ad916c3b124663d3eac0b8c381187aea53eef https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 23 : diff -r 493ad916c3b124663d3eac0b8c381187aea53eef https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 24 : diff -r 493ad916c3b124663d3eac0b8c381187aea53eef https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 25 : diff -r 493ad916c3b124663d3eac0b8c381187aea53eef https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 26 : diff -r 493ad916c3b124663d3eac0b8c381187aea53eef https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 27 : diff -r 493ad916c3b124663d3eac0b8c381187aea53eef https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 28 : diff -r efd786846a76dea6e2e98bb37c09a9af90e34e24 https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 29 : diff -r efd786846a76dea6e2e98bb37c09a9af90e34e24 https://dvyukov%40google.com@code.google.com/p/go/
#
Patch Set 30 : diff -r 81884b89bd88b9d2e4cb7d1219ccaf95b9211939 https://dvyukov%40google.com@code.google.com/p/go/
#
Created:
9 years, 4 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+2478 lines, -41 lines
)
Patch
M
src/cmd/go/doc.go
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
1 chunk
+4 lines, -0 lines
0 comments
Download
M
src/cmd/go/test.go
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
1 chunk
+4 lines, -0 lines
0 comments
Download
M
src/cmd/go/testflag.go
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
3 chunks
+3 lines, -1 line
0 comments
Download
A
src/cmd/trace/trace.go
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
1 chunk
+1443 lines, -0 lines
0 comments
Download
M
src/net/http/pprof/pprof.go
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
3 chunks
+29 lines, -0 lines
0 comments
Download
M
src/runtime/chan.go
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
6 chunks
+6 lines, -6 lines
0 comments
Download
M
src/runtime/malloc.go
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
3 chunks
+10 lines, -1 line
0 comments
Download
M
src/runtime/malloc1.go
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
1 chunk
+3 lines, -0 lines
0 comments
Download
M
src/runtime/mgc.go
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
6 chunks
+26 lines, -0 lines
0 comments
Download
M
src/runtime/mgc0.go
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
1 chunk
+1 line, -1 line
0 comments
Download
M
src/runtime/mheap.go
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
2 chunks
+6 lines, -0 lines
0 comments
Download
M
src/runtime/netpoll.go
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
1 chunk
+1 line, -1 line
0 comments
Download
M
src/runtime/pprof/pprof.go
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
1 chunk
+20 lines, -0 lines
0 comments
Download
M
src/runtime/proc.go
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
5 chunks
+6 lines, -5 lines
0 comments
Download
M
src/runtime/proc1.go
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
33 chunks
+176 lines, -18 lines
0 comments
Download
M
src/runtime/runtime2.go
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
3 chunks
+5 lines, -0 lines
0 comments
Download
M
src/runtime/select.go
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
2 chunks
+2 lines, -2 lines
0 comments
Download
M
src/runtime/sema.go
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
3 chunks
+3 lines, -3 lines
0 comments
Download
M
src/runtime/stack1.go
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
1 chunk
+1 line, -1 line
0 comments
Download
M
src/runtime/time.go
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
2 chunks
+2 lines, -2 lines
0 comments
Download
A
src/runtime/trace.go
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
1 chunk
+710 lines, -0 lines
0 comments
Download
M
src/testing/testing.go
View
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
3 chunks
+17 lines, -0 lines
0 comments
Download
Issue 146920043: runtime: trace
Created 9 years, 7 months ago by dvyukov
Modified 9 years, 4 months ago
Reviewers:
Base URL:
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b
