Tentative flow control API

Tentative flow control API

[GvR, 2013-10-11 23:18:06]

https://codereview.appspot.com/14613043/diff/1/tulip/protocols.py
File tulip/protocols.py (right):

https://codereview.appspot.com/14613043/diff/1/tulip/protocols.py#newcode48
tulip/protocols.py:48: NOTE: This is the only Protocol callback that is not
called
Actually this applies to resume_writing() too.

https://codereview.appspot.com/14613043/diff/1/tulip/selector_events.py
File tulip/selector_events.py (right):

https://codereview.appspot.com/14613043/diff/1/tulip/selector_events.py#newco...
tulip/selector_events.py:493: except (BlockingIOError, InterruptedError) as exc:
[Don't need the exc variable]

https://codereview.appspot.com/14613043/diff/1/tulip/streams.py
File tulip/streams.py (right):

https://codereview.appspot.com/14613043/diff/1/tulip/streams.py#newcode56
tulip/streams.py:56: self._stream_reader = stream_reader
Maybe just call it _reader?

https://codereview.appspot.com/14613043/diff/1/tulip/streams.py#newcode143
tulip/streams.py:143: raise self._writer._exception
This may be the most controversial thing -- if an exception is set on the
reader, drain() will raise that exception every time it is called (as will all
the read*() operations on the reader).

https://codereview.appspot.com/14613043/diff/1/tulip/streams.py#newcode167
tulip/streams.py:167: self.waiter = None  # A future.
(Off-topic, all these instance variables should get an underscore.)

https://codereview.appspot.com/14613043/diff/1/tulip/transports.py
File tulip/transports.py (right):

https://codereview.appspot.com/14613043/diff/1/tulip/transports.py#newcode70
tulip/transports.py:70: """
The implemented defaults are high=256K and low=high/4.

This actually computes a 3rd value too: the "hundred year flood" level -- if the
buffer goes over that, write() will raise.  The implemented default is the
larger of 10M and 10*high.

[GvR, 2013-10-12 04:20:53]

https://codereview.appspot.com/14613043/diff/8001/tulip/selectors.py
File tulip/selectors.py (right):

https://codereview.appspot.com/14613043/diff/8001/tulip/selectors.py#newcode370
tulip/selectors.py:370: timeout = 10 if timeout is None else max(timeout, 0)
[Ignore the debug hackery in this file]

[GvR, 2013-10-12 04:21:51]

https://codereview.appspot.com/14613043/diff/8001/tulip/selector_events.py
File tulip/selector_events.py (right):

https://codereview.appspot.com/14613043/diff/8001/tulip/selector_events.py#ne...
tulip/selector_events.py:524: self._maybe_resume_protocol()  # !!!
This was my bug.

[GvR, 2013-10-13 00:48:54]

(Also merged in the SNI for SSL patch.)

https://codereview.appspot.com/14613043/diff/15001/examples/source1.py
File examples/source1.py (right):

https://codereview.appspot.com/14613043/diff/15001/examples/source1.py#newcode34
examples/source1.py:34: host, port = '127.0.0.1', 1111
I should just use argparse, like the echo examples.