Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(93)

Issue 14607044: In cpplint, permit Dodxygen C++ annotations, which come after members

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by burnus
Modified:
11 years ago
Reviewers:
Mark Mentovai, erg
CC:
Mark Mentovai
Base URL:
http://google-styleguide.googlecode.com/svn/trunk/
Visibility:
Public.

Description

In cpplint, permit Dodxygen C++ annotations, which come after members, e.g. int var; //!< Brief description after the member or int var; ///< Brief description after the member Cf. http://www.stack.nl/~dimitri/doxygen/manual/docblocks.html#memberdoc Currently, cpplint accepts comments after members, cf. http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Implementation_Comments#Implementation_Comments and it accepts also the doxygen comments of the type "///" (followed by a new line) and "/// " (followed by a comment). Only the Doxygen annotations, which come after members are rejected, which is fixed by this patch.

Patch Set 1 #

Patch Set 2 : Permit after-member Doxygen comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M cpplint/cpplint.py View 1 1 chunk +5 lines, -0 lines 0 comments Download
M cpplint/cpplint_unittest.py View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4
burnus
Permit after-member Doxygen comments Re-diff and added unit tests.
11 years ago (2013-10-30 13:22:02 UTC) #1
burnus
I think it is a rather simple and obvious patch - hence, I'd pleased if ...
11 years ago (2013-10-30 13:26:07 UTC) #2
erg
mmentovai: What do you think? The style guide, internal or open-source, doesn't actually mention doxygen ...
11 years ago (2013-10-30 19:14:33 UTC) #3
erg
11 years ago (2013-10-31 19:47:48 UTC) #4
Thank you for your patch. It has been committed as
https://code.google.com/p/google-styleguide/source/detail?r=116.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b