Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12)

Issue 146041: Various cleanup (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 7 months ago by MikeSamuel
Modified:
16 years, 7 months ago
Reviewers:
metaweta
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

1. Updated CssLexer to use CharProducer properly and got rid of the old lookahead and read() methods. 2. Fixed a few HtmlQuasiBuilder bugs around attributes, and problematic tags like <option> and <td> which are ignored by HTML5 rules unless they appear inside ceratin elements. 3. Upgraded to a moder version of servlet.jar to get rid of noisy warnings from webdriver when running DomitaTest 4. Made CharProducer a CharSequence so that it can fit better with the snippet producers. 5. Fixed Scope around "this" and "arguments" 6. Changed parse tree nodes for "finally", "catch", "try" blocks to reflect the fact that they cannot be followed by a non-block statement. E.g. try foo(); catch (e) bar(); is syntactically invalid. 7. Added a renderBody method to function so that we can render programs without an extra set of curly braces. 8. Removed unused imports from CompileHtmlStage and cleaned up warnings in CajolingService 9. Moved optimization specific code from BuildServiceImplementation to a new class JsOptimizer. 10. Changed RenderContext to allow better minified rendering of object ctors. Submitted @3832

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+753 lines, -452 lines) Patch
M src/com/google/caja/ancillary/jsdoc/JsdocMain.java View 2 chunks +1 line, -9 lines 0 comments Download
A src/com/google/caja/ancillary/opt/JsOptimizer.java View 1 chunk +116 lines, -0 lines 0 comments Download
M src/com/google/caja/lexer/CharProducer.java View 5 chunks +54 lines, -15 lines 0 comments Download
M src/com/google/caja/lexer/CssLexer.java View 14 chunks +248 lines, -316 lines 0 comments Download
M src/com/google/caja/parser/html/HtmlQuasiBuilder.java View 6 chunks +60 lines, -14 lines 0 comments Download
M src/com/google/caja/parser/js/Block.java View 3 chunks +7 lines, -2 lines 0 comments Download
M src/com/google/caja/parser/js/CatchStmt.java View 2 chunks +5 lines, -5 lines 0 comments Download
M src/com/google/caja/parser/js/FinallyStmt.java View 1 chunk +7 lines, -6 lines 0 comments Download
M src/com/google/caja/parser/js/ObjectConstructor.java View 2 chunks +11 lines, -1 line 0 comments Download
M src/com/google/caja/parser/js/Operation.java View 1 chunk +7 lines, -0 lines 0 comments Download
M src/com/google/caja/parser/js/Parser.java View 4 chunks +13 lines, -4 lines 0 comments Download
M src/com/google/caja/parser/js/TryStmt.java View 4 chunks +4 lines, -4 lines 0 comments Download
M src/com/google/caja/parser/quasiliteral/CajitaRewriter.java View 4 chunks +4 lines, -4 lines 0 comments Download
M src/com/google/caja/parser/quasiliteral/Scope.java View 2 chunks +13 lines, -0 lines 0 comments Download
M src/com/google/caja/plugin/BuildServiceImplementation.java View 6 chunks +10 lines, -42 lines 0 comments Download
M src/com/google/caja/plugin/PluginCompilerMain.java View 1 chunk +1 line, -1 line 0 comments Download
M src/com/google/caja/plugin/stages/CompileHtmlStage.java View 3 chunks +2 lines, -5 lines 0 comments Download
M src/com/google/caja/render/JsMinimalPrinter.java View 1 chunk +1 line, -0 lines 0 comments Download
M src/com/google/caja/reporting/RenderContext.java View 2 chunks +19 lines, -6 lines 0 comments Download
M src/com/google/caja/service/CajolingService.java View 4 chunks +7 lines, -5 lines 0 comments Download
M src/com/google/caja/util/Lists.java View 1 chunk +6 lines, -6 lines 0 comments Download
M tests/com/google/caja/lexer/CssLexerTest.java View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/com/google/caja/parser/html/HtmlQuasiBuilderTest.java View 2 chunks +35 lines, -0 lines 1 comment Download
M tests/com/google/caja/parser/js/ExpressionTest.java View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/com/google/caja/parser/quasiliteral/ScopeTest.java View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/com/google/caja/reporting/SnippetProducerTest.java View 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/service/TestHttpServletRequest.java View 2 chunks +56 lines, -0 lines 0 comments Download
M tests/com/google/caja/service/TestHttpServletResponse.java View 2 chunks +35 lines, -0 lines 0 comments Download
A tests/com/google/caja/util/Assertion.java View 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/java/jsdk2.1/servlet.jar View Binary file 0 comments Download

Messages

Total messages: 2
MikeSamuel
16 years, 7 months ago (2009-11-02 17:50:20 UTC) #1
metaweta
16 years, 7 months ago (2009-11-02 20:17:08 UTC) #2
LGTM

http://codereview.appspot.com/146041/diff/1/4
File tests/com/google/caja/parser/html/HtmlQuasiBuilderTest.java (right):

http://codereview.appspot.com/146041/diff/1/4#newcode245
Line 245: public final void testProblematicElements() throws Exception {
good tests
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b