Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 14546044: provider/maas: Handle ip_addresses not existing

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by gz
Modified:
10 years, 7 months ago
Reviewers:
mp+189899, fwereade
Visibility:
Public.

Description

provider/maas: Handle ip_addresses not existing Older MAAS versions do not return the ip_addresses field in their instance json. Update the provider to not treat this as an error, but instead equivalent to having no further addresses beyond the seperately exposed DNS name. Cherrypicked fix from trunk to the 1.16 branch. https://code.launchpad.net/~gz/juju-core/1.16_maas_missing_ip_addresses_1236734/+merge/189899 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -24 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M provider/maas/instance.go View 1 chunk +6 lines, -1 line 0 comments Download
M provider/maas/instance_test.go View 2 chunks +50 lines, -23 lines 0 comments Download

Messages

Total messages: 2
gz
Please take a look.
10 years, 7 months ago (2013-10-08 15:58:53 UTC) #1
fwereade
10 years, 7 months ago (2013-10-08 16:16:12 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b