Issue 14543043: provider/maas: Handle ip_addresses not existing

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14543043: provider/maas: Handle ip_addresses not existing

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by gz

Modified:
10 years, 7 months ago

Reviewers:
mp+189847, fwereade, rog

Visibility:
Public.

Description

provider/maas: Handle ip_addresses not existing Older MAAS versions do not return the ip_addresses field in their instance json. Update the provider to not treat this as an error, but instead equivalent to having no further addresses beyond the seperately exposed DNS name. https://code.launchpad.net/~gz/juju-core/maas_missing_ip_addresses_1236734/+merge/189847 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -10 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	provider/maas/instance.go	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	provider/maas/instance_test.go	View	3 chunks	+51 lines, -9 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rog

LGTM with one minor suggestion. https://codereview.appspot.com/14543043/diff/1/provider/maas/instance_test.go File provider/maas/instance_test.go (right): https://codereview.appspot.com/14543043/diff/1/provider/maas/instance_test.go#newcode90 provider/maas/instance_test.go:90: "DNS name", I'd prefer ...

10 years, 7 months ago (2013-10-08 13:50:14 UTC) #2

LGTM, thanks. Can you test this live?

Expand All Messages | Collapse All Messages