On 2013/10/09 18:22:46, Geoff Lang wrote: > Jamie: > If you remember the specific HRESULT ...
10 years, 6 months ago
(2013-10-09 18:30:11 UTC)
#3
On 2013/10/09 18:22:46, Geoff Lang wrote:
> Jamie:
> If you remember the specific HRESULT we got when creation failed we could
check
> that too before returning this error.
Yeah-- my only comment would be that I hope Windows doesn't do anything really
silly like return context lost for this case. I doubt it does, but it'd be nice
to be able to check the error specifically.
On 2013/10/09 18:30:11, Shannon Woods wrote: > On 2013/10/09 18:22:46, Geoff Lang wrote: > > ...
10 years, 6 months ago
(2013-10-09 18:30:23 UTC)
#4
On 2013/10/09 18:30:11, Shannon Woods wrote:
> On 2013/10/09 18:22:46, Geoff Lang wrote:
> > Jamie:
> > If you remember the specific HRESULT we got when creation failed we could
> check
> > that too before returning this error.
>
> Yeah-- my only comment would be that I hope Windows doesn't do anything really
> silly like return context lost for this case. I doubt it does, but it'd be
nice
> to be able to check the error specifically.
(LGTM otherwise.)
On 2013/10/09 18:30:23, Shannon Woods wrote: > On 2013/10/09 18:30:11, Shannon Woods wrote: > > ...
10 years, 6 months ago
(2013-10-09 18:56:52 UTC)
#5
On 2013/10/09 18:30:23, Shannon Woods wrote:
> On 2013/10/09 18:30:11, Shannon Woods wrote:
> > On 2013/10/09 18:22:46, Geoff Lang wrote:
> > > Jamie:
> > > If you remember the specific HRESULT we got when creation failed we could
> > check
> > > that too before returning this error.
> >
> > Yeah-- my only comment would be that I hope Windows doesn't do anything
really
> > silly like return context lost for this case. I doubt it does, but it'd be
> nice
> > to be able to check the error specifically.
>
> (LGTM otherwise.)
LGTM, I don't recall the exact error. I remember the ASSERT was failing, and
that just calls FAILED(hr).
Issue 14540050: Only check for missmatched HWND process IDs if swap chain creation fails.
(Closed)
Created 10 years, 6 months ago by Geoff Lang
Modified 10 years, 6 months ago
Reviewers: Shannon Woods, John Bauman, Jamie Madill
Base URL: https://code.google.com/p/angleproject/@master
Comments: 0