Issue 14532049: Fall back to LoadLibrary if preloading d3d compiler modules fails.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14532049: Fall back to LoadLibrary if preloading d3d compiler modules fails. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by Geoff Lang

Modified:
10 years, 6 months ago

Reviewers:
Zhenyao Mo, Shannon Woods, Jamie Madill

CC:
angleproject-review_googlegroups.com

Base URL:
https://code.google.com/p/angleproject/@master

Visibility:
Public.

More Reviews

Description

Fall back to LoadLibrary if preloading d3d compiler modules fails. Currently ANGLE_PRELOADED_D3DCOMPILER_MODULE_NAMES is defined in all GYP builds but we fail to load the compiler DLLs unless we are loaded by chrome first so standalone apps and samples will not run at all. Instead of either using GetModuleHandleEx or LoadLibrary, fall back to LoadLibrary if GetModuleHandleEx fails. BUG=

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	src/libGLESv2/renderer/Renderer.cpp	View		1 chunk	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Shannon Woods

On 2013/10/09 14:02:48, Geoff Lang wrote: > PTAL Also LGTM

10 years, 6 months ago (2013-10-09 14:50:26 UTC) #2

Jamie Madill

On 2013/10/09 14:50:26, Shannon Woods wrote: > On 2013/10/09 14:02:48, Geoff Lang wrote: > > ...

10 years, 6 months ago (2013-10-09 16:16:11 UTC) #3

Zhenyao Mo

10 years, 6 months ago (2013-10-09 17:00:57 UTC) #4

On 2013/10/09 16:16:11, Jamie Madill wrote:
> On 2013/10/09 14:50:26, Shannon Woods wrote:
> > On 2013/10/09 14:02:48, Geoff Lang wrote:
> > > PTAL
> > 
> > Also LGTM
> 
> Also also LGTM

Also also also LGTM

Expand All Messages | Collapse All Messages