Issue 1451044: code review 1451044: fmt.Scanf: implement formats, provide Sscanf (strings)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1451044: code review 1451044: fmt.Scanf: implement formats, provide Sscanf (strings) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by r

Modified:
14 years, 9 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

fmt.Scanf: implement formats, provide Sscanf (strings) - provide convenience functions for scanning strings - enable Scanf etc. - update doc comments

Patch Set 2 : code review 1451044: fmt.Scanf: implement formats, provide Sscanf (strings) #

Total comments: 2

Patch Set 3 : code review 1451044: fmt.Scanf: implement formats, provide Sscanf (strings) #

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+173 lines, -56 lines)			Patch
M	src/pkg/fmt/print.go	View	1 2	1 chunk	+33 lines, -6 lines	0 comments	Download
M	src/pkg/fmt/scan.go	View	1 2	6 chunks	+105 lines, -40 lines	0 comments	Download
M	src/pkg/fmt/scan_test.go	View	1 2	5 chunks	+35 lines, -10 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 9 months ago (2010-06-02 18:25:43 UTC) #1

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 9 months ago (2010-06-02 18:26:23 UTC) #2

gri1

PS: Note that slice types are illegal as map keys. - Robert On Wed, Jun ...

14 years, 9 months ago (2010-06-02 20:22:44 UTC) #3

rsc1

LGTM http://codereview.appspot.com/1451044/diff/3001/4001 File src/pkg/fmt/print.go (right): http://codereview.appspot.com/1451044/diff/3001/4001#newcode111 src/pkg/fmt/print.go:111: Scan() (that is, it implements the Scanner interface) ...

14 years, 9 months ago (2010-06-02 20:49:47 UTC) #4

14 years, 9 months ago (2010-06-02 21:58:33 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=1391586e4c98 ***

fmt.Scanf: implement formats, provide Sscanf (strings)
- provide convenience functions for scanning strings
- enable Scanf etc.
- update doc comments

R=rsc
CC=golang-dev
http://codereview.appspot.com/1451044

Expand All Messages | Collapse All Messages