Issue 14494054: Don't pass through empty constraints

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14494054: Don't pass through empty constraints

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by thumper

Modified:
10 years, 6 months ago

Reviewers:
mp+190851, axw

Visibility:
Public.

Description

Don't pass through empty constraints If there are no constraints to pass through, cloud init has --constraints '' It seems that somewhere in the process, the empty param is getting missed and the following --debug param is getting parsed as a constraint value. The test is horrible, and all we really care about is the jujud bootstrap-state line. https://code.launchpad.net/~thumper/juju-core/bootstrap-state-no-constraints/+merge/190851 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Don't pass through empty constraints #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -1 line)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/cloudinit/cloudinit.go	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	environs/cloudinit/cloudinit_test.go	View	1	1 chunk	+69 lines, -0 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

axw

10 years, 6 months ago (2013-10-14 03:26:25 UTC) #3

LGTM. Should log a couple of bugs: one to investigate why the quotes are lost,
and one one to fix the testing situation.

https://codereview.appspot.com/14494054/diff/4001/environs/cloudinit/cloudini...
File environs/cloudinit/cloudinit_test.go (right):

https://codereview.appspot.com/14494054/diff/4001/environs/cloudinit/cloudini...
environs/cloudinit/cloudinit_test.go:123: // NOTE: this is terrible, only want
to test part of the results...
Indeed :(

Expand All Messages | Collapse All Messages