Issue 14483043: environs/httpstorage: cleanup

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14483043: environs/httpstorage: cleanup

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by axw

Modified:
10 years, 7 months ago

Reviewers:
mp+189545, fwereade

Visibility:
Public.

Description

environs/httpstorage: cleanup - s/authoris/authoriz/ - use net.SplitHostPort, and cater for req.Host not containing a port - test HEAD response Location URL, to ensure it's valid for the storage https://code.launchpad.net/~axwalk/juju-core/httpstorage-cleanup/+merge/189545 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/httpstorage: cleanup #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -25 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/httpstorage/backend.go	View	3 chunks	+31 lines, -18 lines	0 comments	Download
M	environs/httpstorage/backend_test.go	View	5 chunks	+27 lines, -7 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

LGTM, looks like an improvement to me :).

Expand All Messages | Collapse All Messages