Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(90)

Issue 14439065: Remove Java code for CSS parser and JS rewriting including tracing. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by kpreid2
Modified:
12 years, 4 months ago
Reviewers:
ihab.awad
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Removing: * TracingRewriter * Rewriter, Rule, etc. * CssParser and CssTree * Synthetic nodes @r5615

Patch Set 1 #

Patch Set 2 : Remove Java code for CSS parser and JS rewriting including tracing. #

Total comments: 8

Patch Set 3 : Remove Java code for CSS parser and JS rewriting including tracing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -13465 lines) Patch
M src/com/google/caja/ancillary/opt/ParseTreeKB.java View 2 chunks +1 line, -2 lines 0 comments Download
M src/com/google/caja/ancillary/opt/ScopeInfo.java View 2 chunks +1 line, -2 lines 0 comments Download
M src/com/google/caja/parser/AbstractParseTreeNode.java View 3 chunks +0 lines, -11 lines 0 comments Download
M src/com/google/caja/parser/ParserContext.java View 3 chunks +0 lines, -11 lines 0 comments Download
M src/com/google/caja/parser/css/CssParser.java View 1 2 1 chunk +0 lines, -1319 lines 0 comments Download
M src/com/google/caja/parser/css/CssPropertySignature.java View 1 2 3 chunks +64 lines, -1 line 0 comments Download
D src/com/google/caja/parser/css/CssTree.java View 1 chunk +0 lines, -1765 lines 0 comments Download
D src/com/google/caja/parser/js/SyntheticNodes.java View 1 chunk +0 lines, -86 lines 0 comments Download
D src/com/google/caja/parser/quasiliteral/AlphaRenaming.java View 1 chunk +0 lines, -221 lines 0 comments Download
D src/com/google/caja/parser/quasiliteral/AlphaRenamingRewriter.java View 1 chunk +0 lines, -460 lines 0 comments Download
D src/com/google/caja/parser/quasiliteral/DojoRuleDoclet.java View 1 chunk +0 lines, -85 lines 0 comments Download
D src/com/google/caja/parser/quasiliteral/HtmlRuleDoclet.java View 1 chunk +0 lines, -153 lines 0 comments Download
D src/com/google/caja/parser/quasiliteral/IllegalReferenceCheckRewriter.java View 1 chunk +0 lines, -74 lines 0 comments Download
D src/com/google/caja/parser/quasiliteral/JsonRuleDoclet.java View 1 chunk +0 lines, -74 lines 0 comments Download
D src/com/google/caja/parser/quasiliteral/NodeTypeFilter.java View 1 chunk +0 lines, -34 lines 0 comments Download
D src/com/google/caja/parser/quasiliteral/NonAsciiCheckVisitor.java View 1 chunk +0 lines, -51 lines 0 comments Download
M src/com/google/caja/parser/quasiliteral/QuasiBuilder.java View 6 chunks +9 lines, -41 lines 0 comments Download
M src/com/google/caja/parser/quasiliteral/QuasiNode.java View 2 chunks +2 lines, -1 line 0 comments Download
D src/com/google/caja/parser/quasiliteral/Rewriter.java View 1 chunk +0 lines, -301 lines 0 comments Download
D src/com/google/caja/parser/quasiliteral/Rule.java View 1 chunk +0 lines, -742 lines 0 comments Download
D src/com/google/caja/parser/quasiliteral/RuleChain.java View 1 chunk +0 lines, -55 lines 0 comments Download
D src/com/google/caja/parser/quasiliteral/RuleDoclet.java View 1 chunk +0 lines, -107 lines 0 comments Download
D src/com/google/caja/parser/quasiliteral/RuleFilter.java View 1 chunk +0 lines, -81 lines 0 comments Download
M src/com/google/caja/parser/quasiliteral/Scope.java View 1 2 13 chunks +22 lines, -32 lines 0 comments Download
D src/com/google/caja/parser/quasiliteral/SpecialOpFilter.java View 1 chunk +0 lines, -48 lines 0 comments Download
D src/com/google/caja/parser/quasiliteral/SyntheticQuasiNode.java View 1 chunk +0 lines, -51 lines 0 comments Download
M src/com/google/caja/parser/quasiliteral/TrailingUnderscoresHole.java View 2 chunks +0 lines, -2 lines 0 comments Download
D src/com/google/caja/parser/quasiliteral/WikiRuleDoclet.java View 1 chunk +0 lines, -89 lines 0 comments Download
D src/com/google/caja/plugin/SafeUriLiteral.java View 1 chunk +0 lines, -28 lines 0 comments Download
D src/com/google/caja/plugin/UnsafeUriLiteral.java View 1 chunk +0 lines, -34 lines 0 comments Download
M src/com/google/caja/service/CajolingService.java View 2 chunks +1 line, -3 lines 0 comments Download
D src/com/google/caja/tracing/TracingHandler.java View 1 chunk +0 lines, -155 lines 0 comments Download
D src/com/google/caja/tracing/TracingRewriter.java View 1 chunk +0 lines, -517 lines 0 comments Download
D src/com/google/caja/tracing/TracingRewriterMain.java View 1 chunk +0 lines, -173 lines 0 comments Download
D src/com/google/caja/tracing/tracing.js View 1 chunk +0 lines, -165 lines 0 comments Download
M tests/com/google/caja/parser/ParseTreeNodeTest.java View 2 chunks +0 lines, -5 lines 0 comments Download
M tests/com/google/caja/parser/ParserContextTest.java View 3 chunks +0 lines, -15 lines 0 comments Download
D tests/com/google/caja/parser/css/CssParserTest.java View 1 chunk +0 lines, -337 lines 0 comments Download
D tests/com/google/caja/parser/css/CssTreeTest.java View 1 chunk +0 lines, -219 lines 0 comments Download
D tests/com/google/caja/parser/css/cssparsergolden-filters.txt View 1 chunk +0 lines, -739 lines 0 comments Download
D tests/com/google/caja/parser/css/cssparsergolden-uahacks.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D tests/com/google/caja/parser/css/cssparsergolden1.txt View 1 chunk +0 lines, -1301 lines 0 comments Download
D tests/com/google/caja/parser/css/cssparsergolden2.txt View 1 chunk +0 lines, -231 lines 0 comments Download
D tests/com/google/caja/parser/css/cssparsergolden3.txt View 1 chunk +0 lines, -41 lines 0 comments Download
D tests/com/google/caja/parser/css/cssparsergolden4.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D tests/com/google/caja/parser/css/cssparsergolden5.txt View 1 chunk +0 lines, -249 lines 0 comments Download
D tests/com/google/caja/parser/css/cssparsergolden6.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D tests/com/google/caja/parser/css/cssparsergolden7.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D tests/com/google/caja/parser/css/cssparserinput-filters.css View 1 chunk +0 lines, -168 lines 0 comments Download
D tests/com/google/caja/parser/css/cssparserinput-uahacks.css View 1 chunk +0 lines, -2 lines 0 comments Download
D tests/com/google/caja/parser/css/cssparserinput1.css View 1 chunk +0 lines, -118 lines 0 comments Download
D tests/com/google/caja/parser/css/cssparserinput2.css View 1 chunk +0 lines, -51 lines 0 comments Download
D tests/com/google/caja/parser/css/cssparserinput3.css View 1 chunk +0 lines, -8 lines 0 comments Download
D tests/com/google/caja/parser/css/cssparserinput4.css View 1 chunk +0 lines, -3 lines 0 comments Download
D tests/com/google/caja/parser/css/cssparserinput5.css View 1 chunk +0 lines, -89 lines 0 comments Download
D tests/com/google/caja/parser/css/cssparserinput6.css View 1 chunk +0 lines, -4 lines 0 comments Download
D tests/com/google/caja/parser/css/cssparserinput7.css View 1 chunk +0 lines, -4 lines 0 comments Download
D tests/com/google/caja/parser/css/cssrendergolden-filters.css View 1 chunk +0 lines, -145 lines 0 comments Download
D tests/com/google/caja/parser/css/cssrendergolden-uahacks.css View 1 chunk +0 lines, -5 lines 0 comments Download
D tests/com/google/caja/parser/css/cssrendergolden1.txt View 1 chunk +0 lines, -258 lines 0 comments Download
D tests/com/google/caja/parser/css/cssrendergolden2.txt View 1 chunk +0 lines, -57 lines 0 comments Download
D tests/com/google/caja/parser/css/cssrendergolden4.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D tests/com/google/caja/parser/css/cssrendergolden6.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D tests/com/google/caja/parser/css/csssnippets5.txt View 1 chunk +0 lines, -261 lines 0 comments Download
D tests/com/google/caja/parser/css/csssnippets7.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D tests/com/google/caja/parser/quasiliteral/AlphaRenamingTest.java View 1 chunk +0 lines, -392 lines 0 comments Download
D tests/com/google/caja/parser/quasiliteral/CommonJsRewriterTestCase.java View 1 chunk +0 lines, -459 lines 0 comments Download
D tests/com/google/caja/parser/quasiliteral/IllegalReferenceCheckRewriterTest.java View 1 chunk +0 lines, -71 lines 0 comments Download
D tests/com/google/caja/parser/quasiliteral/RewriterTest.java View 1 chunk +0 lines, -162 lines 0 comments Download
D tests/com/google/caja/parser/quasiliteral/RewriterTestCase.java View 1 chunk +0 lines, -360 lines 0 comments Download
M tests/com/google/caja/parser/quasiliteral/ScopeTest.java View 1 chunk +1 line, -1 line 0 comments Download
D tests/com/google/caja/plugin/sanitizergolden2.txt View 1 chunk +0 lines, -96 lines 0 comments Download
D tests/com/google/caja/service/TracingHandlerTest.java View 1 chunk +0 lines, -35 lines 0 comments Download
D tests/com/google/caja/tracing/TracingRewriterTest.java View 1 chunk +0 lines, -166 lines 0 comments Download
D tests/com/google/caja/tracing/tracingRewriterTestAssertTraces.js View 1 chunk +0 lines, -97 lines 0 comments Download
D tests/com/google/caja/tracing/tracingRewriterTestCases.js View 1 chunk +0 lines, -240 lines 0 comments Download
M tests/com/google/caja/util/CajaTestCase.java View 3 chunks +0 lines, -35 lines 0 comments Download
M tests/com/google/caja/util/RhinoExecutor.java View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 5
kpreid2
12 years, 4 months ago (2013-10-16 18:38:44 UTC) #1
kpreid2
Removing: * TracingRewriter * Rewriter, Rule, etc. * CssParser and CssTree * Synthetic nodes
12 years, 4 months ago (2013-10-16 18:44:22 UTC) #2
ihab.awad
lgtm++ The only caveats are the couple of places where it seemed we could go ...
12 years, 4 months ago (2013-10-17 03:32:29 UTC) #3
kpreid2
Removing: * TracingRewriter * Rewriter, Rule, etc. * CssParser and CssTree * Synthetic nodes
12 years, 4 months ago (2013-10-17 16:32:33 UTC) #4
kpreid2
12 years, 4 months ago (2013-10-17 16:33:55 UTC) #5
https://codereview.appspot.com/14439065/diff/3001/src/com/google/caja/parser/...
File src/com/google/caja/parser/css/CssParser.java (right):

https://codereview.appspot.com/14439065/diff/3001/src/com/google/caja/parser/...
src/com/google/caja/parser/css/CssParser.java:158: public final class CssParser
{
On 2013/10/17 03:32:30, ihab.awad wrote:
> According to my IDE (I patched in your change), nothing in this class is used
> any longer.

2-arg unescape is used by CssPropertySignature. I have moved it there and made
it private.

https://codereview.appspot.com/14439065/diff/3001/src/com/google/caja/parser/...
File src/com/google/caja/parser/quasiliteral/QuasiBuilder.java (right):

https://codereview.appspot.com/14439065/diff/3001/src/com/google/caja/parser/...
src/com/google/caja/parser/quasiliteral/QuasiBuilder.java:59: public class
QuasiBuilder {
On 2013/10/17 03:32:30, ihab.awad wrote:
> This stuff seems to only be used from tests that don't look all that useful.
> Are you sure we can't get rid of it entirely right now?

Something's wrong with your analysis, then. It's used at least in the cajoling
service (constructing the JSON(P) response safely) and in the CSS/HTML schema
file generation.

We might be able to delete some now-unused pieces but that doesn't seem all that
useful towards our goal; better to focus on removing whole classes for now.

https://codereview.appspot.com/14439065/diff/3001/src/com/google/caja/parser/...
File src/com/google/caja/parser/quasiliteral/Scope.java (right):

https://codereview.appspot.com/14439065/diff/3001/src/com/google/caja/parser/...
src/com/google/caja/parser/quasiliteral/Scope.java:59: public class Scope {
On 2013/10/17 03:32:30, ihab.awad wrote:
> This class is only used from com.google.caja.ancillary.opt. Can it be
> getriddified now?

.ancillary.opt is our JS minifier, which we still use. I believe we have talked
about switching to Closure Compiler for minification — should that be put on the
to-do list?

https://codereview.appspot.com/14439065/diff/3001/src/com/google/caja/parser/...
src/com/google/caja/parser/quasiliteral/Scope.java:295: FilePosition.UNKNOWN,
"temp" + (s.tempVariableCounter++) + "_");
On 2013/10/17 03:32:30, ihab.awad wrote:
> Y U H8 KITTEHS?

I misunderstood what the comment was referring to. Restored.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b