Issue 14439053: juju: exposed already implemented unset command

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14439053: juju: exposed already implemented unset command

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by mue

Modified:
11 years, 9 months ago

Reviewers:
mp+190337, jameinel, fwereade

Visibility:
Public.

Description

juju: exposed already implemented unset command The command has already been implemented (and documented *blush*), but not yet exposed. Now it is available. https://code.launchpad.net/~themue/juju-core/052-expose-unset/+merge/190337 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+15 lines, -0 lines)			Patch
[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
cmd/juju/cmd_test.go	View	1 chunk	+11 lines, -0 lines	0 comments	Download
cmd/juju/main.go	View	1 chunk	+1 line, -0 lines	0 comments	Download
cmd/juju/main_test.go	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fwereade

LGTM, thanks. Make sure it goes into 1.16, and tell curtis when it's landed.

11 years, 9 months ago (2013-10-10 11:44:06 UTC) #2

jameinel

11 years, 9 months ago (2013-10-10 11:44:28 UTC) #3

It would be nice to add one test similar to the "sync-tools", "--help" one that
asserts that "unset", "--help" actually does something.

That would be part of TestRunMain() in 'main_test.go'.

Otherwise LGTM

Expand All Messages | Collapse All Messages