Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1998)

Issue 14433060: Issue 351: Reimplement OAuth2 (Step 6): WinRT Support (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by peleyal
Modified:
6 years, 1 month ago
Reviewers:
shovavnik
CC:
google-api-dotnet-client_googlegroup.com, jonskeet
Base URL:
https://google-api-dotnet-client.googlecode.com/hg/
Visibility:
Public.

Description

Issue 351: Reimplement OAuth2 (Step 6): WinRT Support The user code is going to look like this: var credential = await GoogleWebAuthenticationBroker.AuthenticateAsync(new Uri("ms-appx:///Assets/client_secrets.json"), new[] { Uri.EscapeUriString(CalendarService.Scopes.Calendar.GetStringValue()) }, "Eyal", CancellationToken.None); var calendarService = new CalendarService(new BaseClientService.Initializer { HttpClientInitializer = credential, ApplicationName = "APP NAME HERE", }); var list = await calendarService.CalendarList.List().ExecuteAsync();

Patch Set 1 #

Total comments: 14

Patch Set 2 : Noam comments #

Patch Set 3 : minor #

Patch Set 4 : minor #

Patch Set 5 : minor #

Total comments: 2

Patch Set 6 : Noam comments + rename Authenticate to Authorize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+856 lines, -0 lines) Patch
M GoogleApisClient.sln View 1 chunk +112 lines, -0 lines 0 comments Download
A Src/GoogleApis.Auth.WinRT/GoogleApis.Auth.WinRT.csproj View 1 2 3 4 5 1 chunk +164 lines, -0 lines 0 comments Download
A Src/GoogleApis.Auth.WinRT/OAuth2/AuthorizationCodeBroker.cs View 1 2 3 4 5 1 chunk +101 lines, -0 lines 0 comments Download
A Src/GoogleApis.Auth.WinRT/OAuth2/AuthorizationCodeWinRTInstalledApp.cs View 1 1 chunk +70 lines, -0 lines 0 comments Download
A Src/GoogleApis.Auth.WinRT/OAuth2/GoogleWebAuthorizationBroker.cs View 1 2 3 4 5 1 chunk +74 lines, -0 lines 0 comments Download
A Src/GoogleApis.Auth.WinRT/Properties/AssemblyInfo.cs View 1 2 3 4 5 1 chunk +41 lines, -0 lines 0 comments Download
A Src/GoogleApis.Auth.WinRT/packages.config View 1 chunk +8 lines, -0 lines 0 comments Download
A Src/GoogleApis.WinRT/Apis/Util/Store/StorageDataStore.cs View 1 1 chunk +85 lines, -0 lines 0 comments Download
A Src/GoogleApis.WinRT/GoogleApis.WinRT.csproj View 1 chunk +153 lines, -0 lines 0 comments Download
A Src/GoogleApis.WinRT/Properties/AssemblyInfo.cs View 1 2 3 4 5 1 chunk +40 lines, -0 lines 0 comments Download
A Src/GoogleApis.WinRT/packages.config View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6
peleyal
The user code is going to look like this: var credential = await GoogleWebAuthenticationBroker.AuthenticateAsync(new Uri("ms-appx:///Assets/client_secrets.json"), ...
6 years, 2 months ago (2013-10-10 21:00:40 UTC) #1
peleyal
Hi Noam, You can take a look in the CLs which were done so far, ...
6 years, 2 months ago (2013-10-10 21:04:47 UTC) #2
shovavnik
The code looks good. I added some minor recommendations. Note that I do have some ...
6 years, 2 months ago (2013-10-13 03:32:16 UTC) #3
peleyal
Thanks Noam, Hopefully everything is good know so you will be able to LGTM (Looks ...
6 years, 1 month ago (2013-10-15 21:43:50 UTC) #4
shovavnik
Hey Eyal, I added one comment to improve the grammar in a doc comment. Other ...
6 years, 1 month ago (2013-10-17 01:11:03 UTC) #5
peleyal
6 years, 1 month ago (2013-10-17 13:42:45 UTC) #6
Thanks Noam,
I'll push it to the repository in the next minutes.

https://codereview.appspot.com/14433060/diff/25001/Src/GoogleApis.Auth.WinRT/...
File Src/GoogleApis.Auth.WinRT/OAuth2/AuthenticationBroker.cs (right):

https://codereview.appspot.com/14433060/diff/25001/Src/GoogleApis.Auth.WinRT/...
Src/GoogleApis.Auth.WinRT/OAuth2/AuthenticationBroker.cs:61: /// <param
name="tcs">Task completion source which its authorization code response will be
set</param>
On 2013/10/17 01:11:04, shovavnik wrote:
> "Task completion source whose result will be set to the authorization code
> response"

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b