Issue 14386044: environs: return better error from NewFromName

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14386044: environs: return better error from NewFromName

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by rog

Modified:
10 years, 7 months ago

Reviewers:
fwereade, mp+189269

Visibility:
Public.

Description

environs: return better error from NewFromName When an environment isn't bootstrapped, we shouldn't return a config error because there's no environ info. https://code.launchpad.net/~rogpeppe/juju-core/441-fix-NewFromName-error/+merge/189269 Requires: https://code.launchpad.net/~rogpeppe/juju-core/440-fix-addressupdater/+merge/189238 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : environs: return better error from NewFromName #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+125 lines, -33 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/config/config.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	environs/open.go	View	1	4 chunks	+46 lines, -12 lines	0 comments	Download
M	environs/open_test.go	View	1	11 chunks	+76 lines, -20 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

fwereade

LGTM https://codereview.appspot.com/14386044/diff/1/environs/config/config.go File environs/config/config.go (right): https://codereview.appspot.com/14386044/diff/1/environs/config/config.go#newcode590 environs/config/config.go:590: logger.Debugf("coersion failed attributes: %#v, checker: %#v, %v", attrs, ...

10 years, 7 months ago (2013-10-04 11:35:25 UTC) #1

rog

10 years, 7 months ago (2013-10-04 12:20:40 UTC) #2

Please take a look.

https://codereview.appspot.com/14386044/diff/1/environs/config/config.go
File environs/config/config.go (right):

https://codereview.appspot.com/14386044/diff/1/environs/config/config.go#newc...
environs/config/config.go:590: logger.Debugf("coersion failed attributes: %#v,
checker: %#v, %v", attrs, checker, err)
On 2013/10/04 11:35:25, fwereade wrote:
> coercion

Done.

https://codereview.appspot.com/14386044/diff/1/environs/open.go
File environs/open.go (right):

https://codereview.appspot.com/14386044/diff/1/environs/open.go#newcode68
environs/open.go:68: // .jenv file for their currently bootstrapped
environments.
On 2013/10/04 11:35:25, fwereade wrote:
> This should probably be attached to a bug saying we need to convert old
> environments to have .jenvs -- otherwise "when" will be "never"

Done.

Expand All Messages | Collapse All Messages