Issue 14382044: Option to overlay mask over the footage

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14382044: Option to overlay mask over the footage (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by sergey.vfx

Modified:
11 years, 6 months ago

Reviewers:
ideasman42

Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/

Visibility:
Public.

Description

Currently supports only two modes: - Show alpha channel of the mask - Multiply footage by the mask, which will give you final-looking combined image. Uses task scheduler for threading to go task-based threading to be more friendly thread utilization. TODOs: - Currently rasterization happens on every redraw, need to cache rasterized mask somewhere to make redraw more realtime. But where to store this cache and how to invalidate it on mask changes? - Small one: mask shall be displayed below 2D cursor

Patch Set 1 #

Patch Set 2 : Stage 2 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+749 lines, -8 lines)			Patch
release/scripts/startup/bl_ui/properties_mask_common.py	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
source/blender/blenlib/BLI_task.h	View	1	1 chunk	+108 lines, -0 lines	0 comments	Download
source/blender/blenlib/BLI_threads.h	View	1	4 chunks	+14 lines, -0 lines	0 comments	Download
source/blender/blenlib/CMakeLists.txt	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
source/blender/blenlib/intern/task.c	View	1	1 chunk	+414 lines, -0 lines	0 comments	Download
source/blender/blenlib/intern/threads.c	View	1	5 chunks	+52 lines, -0 lines	0 comments	Download
source/blender/editors/include/ED_mask.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
source/blender/editors/mask/mask_draw.c	View	1	4 chunks	+117 lines, -1 line	0 comments	Download
source/blender/editors/screen/glutil.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
source/blender/editors/space_clip/space_clip.c	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
source/blender/editors/space_image/space_image.c	View	1	3 chunks	+5 lines, -2 lines	0 comments	Download
source/blender/editors/space_sequencer/sequencer_draw.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download
source/blender/makesdna/DNA_mask_types.h	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
source/blender/makesdna/DNA_space_types.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
source/blender/makesrna/intern/rna_space.c	View	1	2 chunks	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ideasman42

11 years, 6 months ago (2013-10-09 13:10:56 UTC) #3

LGTM

Caching can be added later (or at least clip rendered area by the view).

Expand All Messages | Collapse All Messages