Issue 14340043: upgrader: Fix bug 124576

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14340043: upgrader: Fix bug 124576 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by dimitern

Modified:
10 years, 7 months ago

Reviewers:
mp+189064, jameinel

Visibility:
Public.

Description

upgrader: Fix bug 124576 Added a flag DisableSSLHostnameVerification to Tools() API call for the upgrader, so that when "ssl-hostname-verification" is false in the environment config, we use a non-validating http client to fetch the tools. https://code.launchpad.net/~dimitern/juju-core/170-bug-1234576-upgrader/+merge/189064 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : upgrader: Fix bug 124576 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -25 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/testing/tools.go	View	1	2 chunks	+12 lines, -0 lines	0 comments	Download
M	state/api/params/internal.go	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	state/api/upgrader/upgrader.go	View		2 chunks	+7 lines, -6 lines	0 comments	Download
M	state/api/upgrader/upgrader_test.go	View	1	3 chunks	+15 lines, -5 lines	0 comments	Download
M	state/apiserver/common/tools.go	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	state/apiserver/common/tools_test.go	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	state/apiserver/upgrader/upgrader_test.go	View	1	2 chunks	+17 lines, -5 lines	0 comments	Download
M	worker/upgrader/upgrader.go	View	1	5 chunks	+19 lines, -7 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jameinel

LGTM, the one test I think we do want to fill in later is a ...

10 years, 7 months ago (2013-10-03 13:11:51 UTC) #2

Please take a look.

Expand All Messages | Collapse All Messages