Issue 14339043: provider/local: implement Instance.Addresses

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14339043: provider/local: implement Instance.Addresses

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by rog

Modified:
10 years, 7 months ago

Reviewers:
dimitern, mp+189058, fwereade

Visibility:
Public.

Description

provider/local: implement Instance.Addresses There doesn't seem to be any testing of Instance.DNSName so there's no easy place to add a test. https://bugs.launchpad.net/juju-core/+bug/1234677 Fixes https://bugs.launchpad.net/juju-core/+bug/1234534 https://code.launchpad.net/~rogpeppe/juju-core/438-local-instance-Addresses/+merge/189058 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : provider/local: implement Instance.Addresses #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	provider/local/instance.go	View		1 chunk	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dimitern

LGTM assuming a live test passes with this. https://codereview.appspot.com/14339043/diff/1/provider/local/instance.go File provider/local/instance.go (right): https://codereview.appspot.com/14339043/diff/1/provider/local/instance.go#newcode31 provider/local/instance.go:31: dnsName, ...

10 years, 7 months ago (2013-10-03 12:40:24 UTC) #2

NOT LGTM. These addresses are not correct.

Expand All Messages | Collapse All Messages