Issue 14327043: environs/sshstorage: join output with newlines

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14327043: environs/sshstorage: join output with newlines

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by rog

Modified:
10 years, 7 months ago

Reviewers:
mp+189008, axw1

Visibility:
Public.

Description

environs/sshstorage: join output with newlines Also a slight simplification - there's no particular need for newLineWrapperWriter to return an error, or for so many different errors when writing to the command's stdin. https://code.launchpad.net/~rogpeppe/juju-core/435-sshstorage-newlines/+merge/189008 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/sshstorage: join output with newlines #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -34 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/sshstorage/linewrapwriter.go	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	environs/sshstorage/linewrapwriter_test.go	View		3 chunks	+4 lines, -9 lines	0 comments	Download
M	environs/sshstorage/storage.go	View		3 chunks	+21 lines, -17 lines	0 comments	Download
M	environs/sshstorage/storage_test.go	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

axw1

10 years, 7 months ago (2013-10-03 08:55:58 UTC) #2

On 2013/10/03 08:47:20, rog wrote:
> Please take a look.

LGTM. I'm +/-1 on splitting the writes out, as it moves the EOFs away from each
other. Should be obvious enough though.

Expand All Messages | Collapse All Messages