Issue 14321043: Allow the network-bridge to be configured.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14321043: Allow the network-bridge to be configured.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by thumper

Modified:
10 years, 7 months ago

Reviewers:
mp+188980, axw1, dave

Visibility:
Public.

Description

Allow the network-bridge to be configured. Enable the local provider config to accept network-bridge. This is then passed through to the container creation netowrk config. A slightly more informative message is added when the bridge is not found. https://code.launchpad.net/~thumper/juju-core/configurable-lxc-bridge/+merge/188980 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -40 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	provider/local/config.go	View	3 chunks	+6 lines, -0 lines	0 comments	Download
M	provider/local/config_test.go	View	2 chunks	+39 lines, -28 lines	0 comments	Download
M	provider/local/environ.go	View	5 chunks	+15 lines, -11 lines	0 comments	Download
M	provider/local/environprovider.go	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	provider/local/instance.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dave_cheney.net

On 2013/10/03 03:19:09, thumper wrote: > Please take a look. LGTM. Trivial Thanks for making ...

10 years, 7 months ago (2013-10-03 03:26:20 UTC) #2

axw1

10 years, 7 months ago (2013-10-03 03:26:30 UTC) #3

On 2013/10/03 03:19:09, thumper wrote:
> Please take a look.

LGTM, tho I wonder if we should be reading /etc/default/lxc to get the right
default. Fine as it is, just a nicety.

Expand All Messages | Collapse All Messages