Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(49)

Issue 1432042: Rocketfuel topology dataset support for topology reader (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by Hajime Tazaki
Modified:
10 years, 9 months ago
Reviewers:
Josh Pelkey
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

The patch aims for the support of rocketfuel topology dataset in TopologyReader. It supports to read the file in order to create Node and NetDevice (p2plink in example script). *Rocketfuel project: http://www.cs.washington.edu/research/networking/rocketfuel/ This patch is against for revision 6326 of ns-3-dev. Comments are welcome.

Patch Set 1 #

Total comments: 3

Patch Set 2 : Update with Josh's comments #

Patch Set 3 : Rename sample file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2452 lines, -2 lines) Patch
A examples/topology-read/RocketFuel_toposample_1239_weights.txt View 1 chunk +1944 lines, -0 lines 0 comments Download
M examples/topology-read/topology-example-sim.cc View 1 chunk +1 line, -1 line 0 comments Download
A src/contrib/topology-read/rocketfuel-topology-reader.h View 1 1 chunk +90 lines, -0 lines 0 comments Download
A src/contrib/topology-read/rocketfuel-topology-reader.cc View 1 2 1 chunk +407 lines, -0 lines 0 comments Download
M src/contrib/topology-read/wscript View 2 chunks +2 lines, -0 lines 0 comments Download
M src/helper/topology-reader-helper.h View 1 chunk +1 line, -1 line 0 comments Download
M src/helper/topology-reader-helper.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M test.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7
Hajime Tazaki
This patchset includes Rocketfuel topology dataset reader. regards, hajime
10 years, 10 months ago (2010-06-02 02:08:06 UTC) #1
Josh Pelkey
This addition to the existing topology reader looks good (assuming it works, I didn't actually ...
10 years, 10 months ago (2010-06-16 17:17:11 UTC) #2
Hajime Tazaki
Thanks, Josh. I've updated the patchset (Patch Set 2). Comments are inline. On 2010/06/16 17:17:11, ...
10 years, 10 months ago (2010-06-17 05:12:14 UTC) #3
Josh Pelkey
Thanks Hajime. The only other thing I thought about was maybe renaming the sample topology ...
10 years, 10 months ago (2010-06-17 15:48:44 UTC) #4
Hajime Tazaki
Thanks Josh. I've changed the name of sample topology file as you suggested. See the ...
10 years, 10 months ago (2010-06-18 03:03:25 UTC) #5
Josh Pelkey
Hajime, Go ahead and push to ns-3-dev when you are ready. Thanks! On 2010/06/18 03:03:25, ...
10 years, 9 months ago (2010-06-21 13:18:44 UTC) #6
Hajime Tazaki
10 years, 9 months ago (2010-06-23 10:25:27 UTC) #7
I've pushed these patchset to ns-3-dev.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b