Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(68)

Issue 143130043: po: Prefer intltool's po/Makefile.in.in to gettext's (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by Daiki Ueno
Modified:
11 years, 4 months ago
Reviewers:
shawn.p.huang, Peng
Base URL:
git@github.com:ibus/ibus-m17n.git@master
Visibility:
Public.

Description

po: Prefer intltool's po/Makefile.in.in to gettext's We currently use intltool to translate ibus-setup-m17n.desktop. However, the po/Makefile.in.in file created by autopoint is no longer compatible with the latest intltool. On the other hand, the latest gettext got support for .desktop file, but I expect some more time until it will be widely adopted. Let's rely on intltool for now. BUG=https://bugzilla.redhat.com/show_bug.cgi?id=1078169 Committed: c87518ff1aafb8f452811b8f79cfd51cdd7764c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M configure.ac View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3
Daiki Ueno
11 years, 4 months ago (2014-09-16 05:48:19 UTC) #1
Peng
lgtm
11 years, 4 months ago (2014-09-18 09:33:20 UTC) #2
Daiki Ueno
11 years, 4 months ago (2014-09-24 06:39:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as c87518f (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b