Issue 142950043: Clear timers at stop() in benchmark.js (to be consistent with xhr_benchmark.js)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 142950043: Clear timers at stop() in benchmark.js (to be consistent with xhr_benchmark.js) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by hiroshige

Modified:
11 years, 3 months ago

Reviewers:
tyoshino (chromium.org)

CC:
pywebsocket-reviews_googlegroups.com

Base URL:
http://pywebsocket.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Clear timers at stop() in benchmark.js (to be consistent with xhr_benchmark.js) R=tyoshino@chromium.org Committed: https://code.google.com/p/pywebsocket/source/detail?r=848

Patch Set 1 : #

Total comments: 2

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	src/example/benchmark.js	View		3 chunks	+6 lines, -0 lines	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

tyoshino (chromium.org)

lgtm https://codereview.appspot.com/142950043/diff/20001/src/example/benchmark.js File src/example/benchmark.js (right): https://codereview.appspot.com/142950043/diff/20001/src/example/benchmark.js#newcode229 src/example/benchmark.js:229: tasks.push(function(){ clear timerID here too?

11 years, 3 months ago (2014-09-12 06:48:12 UTC) #2

hiroshige

https://codereview.appspot.com/142950043/diff/20001/src/example/benchmark.js File src/example/benchmark.js (right): https://codereview.appspot.com/142950043/diff/20001/src/example/benchmark.js#newcode229 src/example/benchmark.js:229: tasks.push(function(){ On 2014/09/12 06:48:11, tyoshino (Chromium) wrote: > clear ...

11 years, 3 months ago (2014-09-12 06:53:53 UTC) #3

hiroshige

11 years, 3 months ago (2014-09-12 06:54:34 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:20001) manually as r848 (presubmit successful).

Expand All Messages | Collapse All Messages