Issue 14294046: Use ANGLE_TRANSLATOR_STATIC to enforce a static build of the translator in chromium.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14294046: Use ANGLE_TRANSLATOR_STATIC to enforce a static build of the translator in chromium. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by Jamie Madill

Modified:
10 years, 6 months ago

Reviewers:
Zhenyao Mo

CC:
angleproject-review_googlegroups.com, nicolas

Base URL:
https://code.google.com/p/angleproject/@master

Visibility:
Public.

More Reviews

Description

Use ANGLE_TRANSLATOR_STATIC to enforce a static build of the translator in chromium. This prevents strange warnings from defining COMPONENT_BUILD=0. Also rename COMPILER_IMPLEMENTATION to ANGLE_TRANSLATOR_IMPLEMENTATION for better consistency in chromium. ANGLEBUG=477 R=zmo@chromium.org BUG= Committed: https://code.google.com/p/angleproject/source/detail?r=a0bd8ef

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -12 lines)			Patch
	M	include/GLSLANG/ShaderLang.h	View		3 chunks	+8 lines, -8 lines	0 comments	Download
	M	src/build_angle.gypi	View		3 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Jamie Madill

10 years, 6 months ago (2013-10-02 21:41:02 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as ra0bd8ef (presubmit successful).

Expand All Messages | Collapse All Messages