Issue 14285043: environs/configstore: fix for Windows

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14285043: environs/configstore: fix for Windows

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by rog

Modified:
10 years, 7 months ago

Reviewers:
natefinch, mp+188873

Visibility:
Public.

Description

environs/configstore: fix for Windows Under Windows you can't rename a file while it's still open. https://code.launchpad.net/~rogpeppe/juju-core/432-configstore-windows-fix/+merge/188873 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/configstore: fix for Windows #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	environs/configstore/disk.go	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

natefinch

10 years, 7 months ago (2013-10-02 15:50:06 UTC) #2

On 2013/10/02 15:43:57, rog wrote:
> Please take a look.

LGTM

Expand All Messages | Collapse All Messages