Make local provider work.

Make local provider work.

lp:1231724 shows that if a local provider is bootstrapped,
the created directory $(JUJU_HOME)/environments is not readable
by the user that started the provider as the bootstrap is done
by root, and the files and directories created are owned by
root with 0600 permission, which means you can't even run
juju status on a bootstrapped local provider.

https://code.launchpad.net/~thumper/juju-core/environments-dir-permission/+merge/188754

(do not edit description out of merge proposal)

[thumper, 2013-10-02 02:32:14]

Please take a look.

[axw1, 2013-10-02 03:25:51]

https://codereview.appspot.com/14258043/diff/1/environs/configstore/disk_test.go
File environs/configstore/disk_test.go (right):

https://codereview.appspot.com/14258043/diff/1/environs/configstore/disk_test...
environs/configstore/disk_test.go:154: s.PatchEnvironment("SUDO_UID", "1000")
I think you may want to use os/user.Current(), or NewDisk will fail due to lack
of permissions to chown (unless you happen to be running as root).

https://codereview.appspot.com/14258043/diff/1/utils/sudo.go
File utils/sudo.go (right):

https://codereview.appspot.com/14258043/diff/1/utils/sudo.go#newcode16
utils/sudo.go:16: func SudoCallerIds() (int, int, error) {
I may be alone here, but I think named results are useful for documentation
here. My eyes usually drift straight to the signature... YMMV

[thumper, 2013-10-02 04:09:43]

Please take a look.

https://codereview.appspot.com/14258043/diff/1/environs/configstore/disk_test.go
File environs/configstore/disk_test.go (right):

https://codereview.appspot.com/14258043/diff/1/environs/configstore/disk_test...
environs/configstore/disk_test.go:154: s.PatchEnvironment("SUDO_UID", "1000")
On 2013/10/02 03:25:52, axw1 wrote:
> I think you may want to use os/user.Current(), or NewDisk will fail due to
lack
> of permissions to chown (unless you happen to be running as root).

Good call.

https://codereview.appspot.com/14258043/diff/1/utils/sudo.go
File utils/sudo.go (right):

https://codereview.appspot.com/14258043/diff/1/utils/sudo.go#newcode16
utils/sudo.go:16: func SudoCallerIds() (int, int, error) {
On 2013/10/02 03:25:52, axw1 wrote:
> I may be alone here, but I think named results are useful for documentation
> here. My eyes usually drift straight to the signature... YMMV

OK

[axw1, 2013-10-02 04:48:59]

On 2013/10/02 04:09:43, thumper wrote:
> Please take a look.
> 
>
https://codereview.appspot.com/14258043/diff/1/environs/configstore/disk_test.go
> File environs/configstore/disk_test.go (right):
> 
>
https://codereview.appspot.com/14258043/diff/1/environs/configstore/disk_test...
> environs/configstore/disk_test.go:154: s.PatchEnvironment("SUDO_UID", "1000")
> On 2013/10/02 03:25:52, axw1 wrote:
> > I think you may want to use os/user.Current(), or NewDisk will fail due to
> lack
> > of permissions to chown (unless you happen to be running as root).
> 
> Good call.
> 
> https://codereview.appspot.com/14258043/diff/1/utils/sudo.go
> File utils/sudo.go (right):
> 
> https://codereview.appspot.com/14258043/diff/1/utils/sudo.go#newcode16
> utils/sudo.go:16: func SudoCallerIds() (int, int, error) {
> On 2013/10/02 03:25:52, axw1 wrote:
> > I may be alone here, but I think named results are useful for documentation
> > here. My eyes usually drift straight to the signature... YMMV
> 
> OK

LGTM. FWIW, I tend to use named results but not bare returns (in case of var
shadowing).