Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(286)

Issue 1425041: Woodwind diagrams (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years ago by Neil Puttock
Modified:
6 years, 2 months ago
Reviewers:
MikeSol, dak, Patrick McCarty, carl.d.sorensen, mike7
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Woodwind diagrams Implements woodwind diagrams in lilypond.

Patch Set 1 #

Total comments: 47

Patch Set 2 : Respond to comments. #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+3902 lines, -61 lines) Patch
A input/regression/woodwind-diagrams-empty.ly View 1 1 chunk +70 lines, -0 lines 0 comments Download
A input/regression/woodwind-diagrams-key-lists.ly View 1 1 chunk +18 lines, -0 lines 0 comments Download
ps/music-drawing-routines.ps View 1 6 chunks +63 lines, -5 lines 1 comment Download
A scm/bezier-tools.scm View 1 chunk +105 lines, -0 lines 0 comments Download
M scm/define-stencil-commands.scm View 2 chunks +2 lines, -0 lines 0 comments Download
M scm/flag-styles.scm View 1 4 chunks +12 lines, -27 lines 0 comments Download
M scm/lily.scm View 2 chunks +2 lines, -1 line 0 comments Download
M scm/lily-library.scm View 1 5 chunks +140 lines, -11 lines 1 comment Download
M scm/output-ps.scm View 1 9 chunks +45 lines, -12 lines 0 comments Download
M scm/output-svg.scm View 1 1 chunk +95 lines, -0 lines 5 comments Download
M scm/stencil.scm View 1 3 chunks +210 lines, -5 lines 0 comments Download
A scm/woodwind-diagrams.scm View 1 1 chunk +3140 lines, -0 lines 0 comments Download

Messages

Total messages: 6
Carl
The new patch worked. I've put some comments in line. Great job, Mike! http://codereview.appspot.com/1425041/diff/1/8 File ...
9 years ago (2010-05-31 14:06:48 UTC) #1
Neil Puttock
Hi Mike, This is super work, you're obviously a schemer extraordinaire. ;) I've copied my ...
9 years ago (2010-05-31 14:48:13 UTC) #2
Carl
Mike, I'm sorry, but I had some comments earlier that I somehow erased with inadvertent ...
9 years ago (2010-05-31 17:47:28 UTC) #3
Patrick McCarty
Hi Mike, This is very impressive. Thanks for your work on this. I just have ...
9 years ago (2010-06-18 22:42:00 UTC) #4
dak
https://codereview.appspot.com/1425041/diff/12001/ps/music-drawing-routines.ps File ps/music-drawing-routines.ps (right): https://codereview.appspot.com/1425041/diff/12001/ps/music-drawing-routines.ps#newcode196 ps/music-drawing-routines.ps:196: +% Note that filled is not boolean to permit ...
6 years, 2 months ago (2013-04-15 12:38:26 UTC) #5
mike7
6 years, 2 months ago (2013-04-15 12:48:38 UTC) #6
On 15 avr. 2013, at 15:38, dak@gnu.org wrote:

> 
>
https://codereview.appspot.com/1425041/diff/12001/ps/music-drawing-routines.ps
> File ps/music-drawing-routines.ps (right):
> 
>
https://codereview.appspot.com/1425041/diff/12001/ps/music-drawing-routines.p...
> ps/music-drawing-routines.ps:196: +% Note that filled is not boolean to
> permit for different graylevels (ie for trill keys)
> What's the reason for this falsehood?  "filled" is quite obviously
> boolean and used as such.

You're right, this comment is wrong.  Seems like filled is only being used for
boolean.

Cheers,
MS

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b