Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(4041)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
14229044
: Issue 383: ExecuteAsync creates unnecessary Task (Closed)
Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by
peleyal
Modified:
11 years, 1 month ago
Reviewers:
Base URL:
https://google-api-dotnet-client.googlecode.com/hg/
Visibility:
Public.
More Reviews
Description
Issue 383: ExecuteAsync creates unnecessary Task
Patch Set 1
#
Patch Set 2 : minor
#
Patch Set 3 : throw TaskCanceledException in case it required
#
Patch Set 4 : minor
#
Created:
11 years, 1 month ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+141 lines, -228 lines
)
Patch
M
Src/GoogleApis.Tests/Apis/Download/MediaDownloaderTest.cs
View
1
2
4 chunks
+5 lines, -13 lines
0 comments
Download
M
Src/GoogleApis.Tests/Apis/Requests/ClientServiceRequestTest.cs
View
3 chunks
+0 lines, -8 lines
0 comments
Download
M
Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs
View
1
2
3
46 chunks
+73 lines, -74 lines
0 comments
Download
M
Src/GoogleApis/Apis/Http/BackOffHandler.cs
View
3 chunks
+3 lines, -3 lines
0 comments
Download
M
Src/GoogleApis/Apis/Requests/ClientServiceRequest.cs
View
6 chunks
+5 lines, -29 lines
0 comments
Download
M
Src/GoogleApis/Apis/[Media]/Download/IMediaDownloader.cs
View
1
2
1 chunk
+4 lines, -0 lines
0 comments
Download
M
Src/GoogleApis/Apis/[Media]/Download/MediaDownloader.cs
View
1
2
8 chunks
+17 lines, -37 lines
0 comments
Download
M
Src/GoogleApis/Apis/[Media]/Upload/ResumableUpload.cs
View
1
2
3
13 chunks
+34 lines, -63 lines
0 comments
Download
M
Src/GoogleApis/GoogleApis.csproj
View
1 chunk
+0 lines, -1 line
0 comments
Download
Issue 14229044: Issue 383: ExecuteAsync creates unnecessary Task (Closed)
Created 11 years, 1 month ago by peleyal
Modified 11 years, 1 month ago
Reviewers:
Base URL: https://google-api-dotnet-client.googlecode.com/hg/
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b