Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(447)

Issue 14229044: Issue 383: ExecuteAsync creates unnecessary Task (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 2 months ago by peleyal
Modified:
6 years, 2 months ago
Reviewers:
Base URL:
https://google-api-dotnet-client.googlecode.com/hg/
Visibility:
Public.

Description

Issue 383: ExecuteAsync creates unnecessary Task

Patch Set 1 #

Patch Set 2 : minor #

Patch Set 3 : throw TaskCanceledException in case it required #

Patch Set 4 : minor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -228 lines) Patch
M Src/GoogleApis.Tests/Apis/Download/MediaDownloaderTest.cs View 1 2 4 chunks +5 lines, -13 lines 0 comments Download
M Src/GoogleApis.Tests/Apis/Requests/ClientServiceRequestTest.cs View 3 chunks +0 lines, -8 lines 0 comments Download
M Src/GoogleApis.Tests/Apis/Upload/ResumableUploadTest.cs View 1 2 3 46 chunks +73 lines, -74 lines 0 comments Download
M Src/GoogleApis/Apis/Http/BackOffHandler.cs View 3 chunks +3 lines, -3 lines 0 comments Download
M Src/GoogleApis/Apis/Requests/ClientServiceRequest.cs View 6 chunks +5 lines, -29 lines 0 comments Download
M Src/GoogleApis/Apis/[Media]/Download/IMediaDownloader.cs View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M Src/GoogleApis/Apis/[Media]/Download/MediaDownloader.cs View 1 2 8 chunks +17 lines, -37 lines 0 comments Download
M Src/GoogleApis/Apis/[Media]/Upload/ResumableUpload.cs View 1 2 3 13 chunks +34 lines, -63 lines 0 comments Download
M Src/GoogleApis/GoogleApis.csproj View 1 chunk +0 lines, -1 line 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b