Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(64)

Issue 14228045: Fix URI policies without fetch causing lost-signal. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by kpreid2
Modified:
12 years, 5 months ago
Reviewers:
felix8a
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fixes <https://code.google.com/p/google-caja/issues/detail?id=1579>. Domado's uriFetch now always invokes its callback, one way or another; particularly if the URI policy object contains no 'fetch' method. @r5609

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix URI policies without fetch causing lost-signal. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -33 lines) Patch
M src/com/google/caja/plugin/domado.js View 1 2 chunks +13 lines, -18 lines 0 comments Download
M tests/com/google/caja/plugin/test-cajajs-invocation.js View 1 3 chunks +44 lines, -15 lines 0 comments Download

Messages

Total messages: 5
kpreid2
12 years, 5 months ago (2013-10-01 20:08:46 UTC) #1
felix8a
https://codereview.appspot.com/14228045/diff/1/src/com/google/caja/plugin/domado.js File src/com/google/caja/plugin/domado.js (right): https://codereview.appspot.com/14228045/diff/1/src/com/google/caja/plugin/domado.js#newcode92 src/com/google/caja/plugin/domado.js:92: window.setTimeout(function() { callback({}); }, 0); this will invoke callback ...
12 years, 5 months ago (2013-10-02 03:43:04 UTC) #2
kpreid2
Fixes <https://code.google.com/p/google-caja/issues/detail?id=1579>. Domado's uriFetch now always invokes its callback, one way or another; particularly if ...
12 years, 5 months ago (2013-10-02 20:36:14 UTC) #3
kpreid2
https://codereview.appspot.com/14228045/diff/1/src/com/google/caja/plugin/domado.js File src/com/google/caja/plugin/domado.js (right): https://codereview.appspot.com/14228045/diff/1/src/com/google/caja/plugin/domado.js#newcode92 src/com/google/caja/plugin/domado.js:92: window.setTimeout(function() { callback({}); }, 0); On 2013/10/02 03:43:04, felix8a ...
12 years, 5 months ago (2013-10-02 20:36:45 UTC) #4
felix8a
12 years, 5 months ago (2013-10-02 22:51:44 UTC) #5
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b