Azure docs and doc cleanup

Azure docs and doc cleanup

Added documentation for the Azure provider and cleaned up the formatting of a bunch of the CLI documentation to be standard about indents and wrapping.

https://code.launchpad.net/~natefinch/juju-core/018-azure-help/+merge/188936

(do not edit description out of merge proposal)

[natefinch, 2013-10-02 21:49:01]

Please take a look.

[dave_cheney.net, 2013-10-03 10:48:19]

Very close, lots of nits.

https://codereview.appspot.com/14207048/diff/1/cmd/juju/help_topics.go
File cmd/juju/help_topics.go (right):

https://codereview.appspot.com/14207048/diff/1/cmd/juju/help_topics.go#newcode40
cmd/juju/help_topics.go:40: This will generate a file, 'environments.yaml',
which will live in your
s/which will live//

https://codereview.appspot.com/14207048/diff/1/cmd/juju/help_topics.go#newcode41
cmd/juju/help_topics.go:41: '~/.juju/' directory (or $JUJU_HOME, if set) and
will create the directory if it
move the description of the directory creation before the generation of the
file.

https://codereview.appspot.com/14207048/diff/1/cmd/juju/help_topics.go#newcode53
cmd/juju/help_topics.go:53: The local provider is a juju environment that uses
LXC containers as a virtual
s/juju/Juju/g

https://codereview.appspot.com/14207048/diff/1/cmd/juju/help_topics.go#newcode54
cmd/juju/help_topics.go:54: cloud on the local machine.  Because of this, lxc
and mongodb the local provider
lxc and mongodb, what ?

https://codereview.appspot.com/14207048/diff/1/cmd/juju/help_topics.go#newcod...
cmd/juju/help_topics.go:135: Configuring the EC2 environment requires telling
juju about your AWS access key
/s/juju/Juju/g

https://codereview.appspot.com/14207048/diff/1/cmd/juju/help_topics.go#newcod...
cmd/juju/help_topics.go:178: environment type for juju, which would look
something like this:
s/juju/Juju everywhere

https://codereview.appspot.com/14207048/diff/1/cmd/juju/help_topics.go#newcod...
cmd/juju/help_topics.go:229: This is the configuration environments.yaml file
needed to run on Windows Azure.
environments.yaml configuration

https://codereview.appspot.com/14207048/diff/1/cmd/juju/main.go
File cmd/juju/main.go (right):

https://codereview.appspot.com/14207048/diff/1/cmd/juju/main.go#newcode24
cmd/juju/main.go:24: such as OpenStack, Amazon AWS, Windows Azure, HP Cloud, or
bare metal.
s/bare metal/MaaS

is it Windows Azure or Azure? I saw just plain azure before.  Should these be
sorted (for fairness)

[natefinch, 2013-10-03 11:20:19]

Please take a look.

[gz, 2013-10-03 16:13:30]

LGTM once comments addressed.

https://codereview.appspot.com/14207048/diff/7001/cmd/juju/addmachine.go
File cmd/juju/addmachine.go (right):

https://codereview.appspot.com/14207048/diff/7001/cmd/juju/addmachine.go#newc...
cmd/juju/addmachine.go:31: `
Hm, have you added new code somewhere that strips of a leading newline?

https://codereview.appspot.com/14207048/diff/7001/cmd/juju/help_topics.go
File cmd/juju/help_topics.go (right):

https://codereview.appspot.com/14207048/diff/7001/cmd/juju/help_topics.go#new...
cmd/juju/help_topics.go:11: such as Amazon AWS, HP Cloud, OpenStack, MaaS, or
your own local machine.
I liked Openstack being first...

https://codereview.appspot.com/14207048/diff/7001/cmd/juju/help_topics.go#new...
cmd/juju/help_topics.go:144: default-series: precise
Remove default-series?

https://codereview.appspot.com/14207048/diff/7001/cmd/juju/help_topics.go#new...
cmd/juju/help_topics.go:145: ssl-hostname-verification: true
Remove this too, even when implemeted it's going to be true by default.

https://codereview.appspot.com/14207048/diff/7001/cmd/juju/help_topics.go#new...
cmd/juju/help_topics.go:216: # default-series: precise
Remove default-series?

[rog, 2013-10-03 16:19:22]

LGTM with some suggestions below.

https://codereview.appspot.com/14207048/diff/1/cmd/juju/help_topics.go
File cmd/juju/help_topics.go (right):

https://codereview.appspot.com/14207048/diff/1/cmd/juju/help_topics.go#newcod...
cmd/juju/help_topics.go:177: HP Cloud is an Openstack cloud provider, so to
deploy to it, use an openstack
s/provider, so/provider. To/

?

https://codereview.appspot.com/14207048/diff/1/cmd/juju/help_topics.go#newcod...
cmd/juju/help_topics.go:182: admin-secret: 6638bebf0c54ffff1007e0247d4dae98
this can go

https://codereview.appspot.com/14207048/diff/1/cmd/juju/help_topics.go#newcod...
cmd/juju/help_topics.go:183: control-bucket:
juju-bc66a4a4adbee50b2ceeee70436528e5
this can go too

https://codereview.appspot.com/14207048/diff/1/cmd/juju/help_topics.go#newcod...
cmd/juju/help_topics.go:207: admin-secret: 35d65be36c72da940933dd02f8d7cef0
d

https://codereview.appspot.com/14207048/diff/1/cmd/juju/main.go
File cmd/juju/main.go (right):

https://codereview.appspot.com/14207048/diff/1/cmd/juju/main.go#newcode23
cmd/juju/main.go:23: juju provides easy, intelligent service orchestration on
top of environments
s/environments/cloud infrastructure providers/ ?

https://codereview.appspot.com/14207048/diff/1/cmd/juju/main.go#newcode24
cmd/juju/main.go:24: such as OpenStack, Amazon AWS, Windows Azure, HP Cloud, or
bare metal.
On 2013/10/03 10:48:19, dfc wrote:
> s/bare metal/MaaS
> 
> is it Windows Azure or Azure? I saw just plain azure before.  Should these be
> sorted (for fairness)

or perhaps ", or on bare hardware using MaaS." ?

https://codereview.appspot.com/14207048/diff/1/cmd/juju/set.go
File cmd/juju/set.go (right):

https://codereview.appspot.com/14207048/diff/1/cmd/juju/set.go#newcode28
cmd/juju/set.go:28: unset command to set one or more configuration options for a
specified service
s/to set/, which sets/

https://codereview.appspot.com/14207048/diff/1/cmd/juju/set.go#newcode29
cmd/juju/set.go:29: to their default.
d/default/default value/

https://codereview.appspot.com/14207048/diff/1/cmd/juju/ssh.go
File cmd/juju/ssh.go (right):

https://codereview.appspot.com/14207048/diff/1/cmd/juju/ssh.go#newcode35
cmd/juju/ssh.go:35: treated as extra parameters for the ssh command.
s/treated as/passed as/
s/for the/to the/
?

https://codereview.appspot.com/14207048/diff/1/cmd/plugins/juju-metadata/vali...
File cmd/plugins/juju-metadata/validateimagemetadata.go (right):

https://codereview.appspot.com/14207048/diff/1/cmd/plugins/juju-metadata/vali...
cmd/plugins/juju-metadata/validateimagemetadata.go:34: The cloud specificaton
comes from the current Juju environment, as specified in
s/specificaton/specification/

https://codereview.appspot.com/14207048/diff/7001/cmd/juju/help_topics.go
File cmd/juju/help_topics.go (right):

https://codereview.appspot.com/14207048/diff/7001/cmd/juju/help_topics.go#new...
cmd/juju/help_topics.go:11: such as Amazon AWS, HP Cloud, OpenStack, MaaS, or
your own local machine.
On 2013/10/03 16:13:30, gz wrote:
> I liked Openstack being first...

Given that we use "ec2" as an identifier throughout,
perhaps it should be better to say "Amazon EC2" here?