Issue 141740043: xhr_event_logger new features (upload event, dump ProgressEvent, response mode)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 141740043: xhr_event_logger new features (upload event, dump ProgressEvent, response mode) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by tyoshino (chromium.org)

Modified:
11 years, 7 months ago

Reviewers:
hiroshige

CC:
pywebsocket-reviews_googlegroups.com, Yutaka Hirano

Base URL:
http://pywebsocket.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

xhr_event_logger new features (upload event, dump ProgressEvent, response mode) R=hiroshige@chromium.org Committed: https://code.google.com/p/pywebsocket/source/detail?r=841

Patch Set 2 : #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -15 lines)			Patch
M	src/example/benchmark.html	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/example/util.js	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/example/xhr_benchmark.html	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/example/xhr_event_logger.html	View	1	3 chunks	+50 lines, -7 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

hiroshige

lgtm https://codereview.appspot.com/141740043/diff/1/src/example/xhr_event_logger.html File src/example/xhr_event_logger.html (right): https://codereview.appspot.com/141740043/diff/1/src/example/xhr_event_logger.html#newcode21 src/example/xhr_event_logger.html:21: events[events.length - 1].count = events[events.length - 1].count + ...

11 years, 7 months ago (2014-09-08 12:01:45 UTC) #2

tyoshino (chromium.org)

https://codereview.appspot.com/141740043/diff/1/src/example/xhr_event_logger.html File src/example/xhr_event_logger.html (right): https://codereview.appspot.com/141740043/diff/1/src/example/xhr_event_logger.html#newcode21 src/example/xhr_event_logger.html:21: events[events.length - 1].count = events[events.length - 1].count + 1; ...

11 years, 7 months ago (2014-09-09 05:29:53 UTC) #3

tyoshino (chromium.org)

11 years, 7 months ago (2014-09-09 05:30:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as r841 (presubmit successful).

Expand All Messages | Collapse All Messages