Issue 14161043: Remove %(AdditionalDependencies) from gyp linker deps, and add full windows dependency library list.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14161043: Remove %(AdditionalDependencies) from gyp linker deps, and add full windows dependency library list. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by Jamie Madill

Modified:
10 years, 6 months ago

Reviewers:
Zhenyao Mo

CC:
angleproject-review_googlegroups.com, Shannon Woods

Base URL:
https://code.google.com/p/angleproject/@master

Visibility:
Public.

More Reviews

Description

Remove %(AdditionalDependencies) from gyp linker deps, and add full windows dependency library list. ANGLEBUG=477 BUG= R=zmo@chromium.org Committed: https://code.google.com/p/angleproject/source/detail?r=7692ca4

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -2 lines)			Patch
	M	build/common.gypi	View		1 chunk	+15 lines, -0 lines	0 comments	Download
	M	src/build_angle.gypi	View		2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Jamie Madill

10 years, 6 months ago (2013-10-01 14:15:35 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r7692ca4 (presubmit successful).

Expand All Messages | Collapse All Messages