Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(44)

Issue 14106: Issue 922: NPE in Valija code using "use strict,cajita"; (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
17 years, 1 month ago by MikeSamuel
Modified:
16 years, 8 months ago
Reviewers:
MarkM
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

In the testbed <script type="text/javascript"> "use strict,cajita"; var foo; (function (){ foo = function () { return 8; }; })(); foo(); </script> works with the Valija checkbox off, but with it on gives: java.lang.NullPointerException at com.google.caja.parser.quasiliteral.Rewriter.expand(Rewriter.java:108) at com.google.caja.parser.quasiliteral.Rule.expandAllTo(Rule.java:193) at com.google.caja.parser.quasiliteral.Rule.expandAll(Rule.java:183) at com.google.caja.parser.quasiliteral.DefaultValijaRewriter$52.fire(DefaultValijaRewriter.java:1379)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M src/com/google/caja/parser/quasiliteral/DefaultValijaRewriter.java View 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/parser/quasiliteral/DefaultValijaRewriterTest.java View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3
MikeSamuel
17 years, 1 month ago (2009-02-17 21:24:10 UTC) #1
MarkM
LGTM
17 years, 1 month ago (2009-02-17 21:26:54 UTC) #2
MikeSamuel
17 years, 1 month ago (2009-02-17 21:35:48 UTC) #3
@3260
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b