Issue 141042: Small change in the cajoling service api to allow the uri policy to be set

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 141042: Small change in the cajoling service api to allow the uri policy to be set (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 8 months ago by Jasvir

Modified:
16 years, 1 month ago

Reviewers:
metaweta

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Changes CajolingService to take a UriCallback object which rewrites uris

Patch Set 1 #

Patch Set 2 : Small change in the cajoling service api to allow the uri policy to be set #

Patch Set 3 : Small change in the cajoling service api to allow the uri policy to be set #

Total comments: 1

Created: 16 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -26 lines)			Patch
	M	src/com/google/caja/service/CajolingService.java	View	1 2	3 chunks	+30 lines, -20 lines	1 comment	Download
	M	src/com/google/caja/service/HtmlHandler.java	View	2	1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

metaweta

16 years, 6 months ago (2009-12-02 23:24:49 UTC) #4

LGTM

http://codereview.appspot.com/141042/diff/2001/2003
File src/com/google/caja/service/CajolingService.java (right):

http://codereview.appspot.com/141042/diff/2001/2003#newcode91
src/com/google/caja/service/CajolingService.java:91: this.host = host;
maybe replace this body with
  this(buildInfo, host, DEFAULT_URIPOLICY);

Expand All Messages | Collapse All Messages