Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(55)

Issue 14103044: tryton-tools: Add reviewbot (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by nicoe
Modified:
11 years, 2 months ago
Reviewers:
jean.cavallo, yangoon, ced
Visibility:
Public.

Description

This is a python script that submits on rietveld instances the result of flake8 runs.

Patch Set 1 #

Total comments: 19

Patch Set 2 : do not send LGTM / guess version and module url #

Total comments: 1

Patch Set 3 : Add comment when everything is fine #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -0 lines) Patch
A reviewbot.py View 1 2 1 chunk +251 lines, -0 lines 0 comments Download

Messages

Total messages: 10
nicoe
12 years, 4 months ago (2013-09-29 21:07:41 UTC) #1
ced
The bot could go into tryton-tools https://codereview.appspot.com/14103044/diff/1/reviewbot.py File reviewbot.py (right): https://codereview.appspot.com/14103044/diff/1/reviewbot.py#newcode20 reviewbot.py:20: REPOSITORIES = { ...
12 years, 4 months ago (2013-09-30 13:41:42 UTC) #2
jean.cavallo
https://codereview.appspot.com/14103044/diff/1/reviewbot.py File reviewbot.py (right): https://codereview.appspot.com/14103044/diff/1/reviewbot.py#newcode58 reviewbot.py:58: self.options.ignore = ('E122', 'E123', 'E124', 'E126', 'E128') Add E711 ...
12 years, 4 months ago (2013-09-30 14:52:12 UTC) #3
yangoon
https://codereview.appspot.com/14103044/diff/1/reviewbot.py File reviewbot.py (right): https://codereview.appspot.com/14103044/diff/1/reviewbot.py#newcode214 reviewbot.py:214: 'Not LGTM: patch is not applicable on trunk') On ...
12 years, 4 months ago (2013-09-30 16:15:52 UTC) #4
nicoe
https://codereview.appspot.com/14103044/diff/1/reviewbot.py File reviewbot.py (right): https://codereview.appspot.com/14103044/diff/1/reviewbot.py#newcode20 reviewbot.py:20: REPOSITORIES = { On 2013/09/30 13:41:42, ced wrote: > ...
12 years, 4 months ago (2013-10-09 21:07:30 UTC) #5
nicoe
12 years, 4 months ago (2013-10-09 21:08:56 UTC) #6
ced
LGTM https://codereview.appspot.com/14103044/diff/9001/reviewbot.py File reviewbot.py (right): https://codereview.appspot.com/14103044/diff/9001/reviewbot.py#newcode223 reviewbot.py:223: finalize_comments(session, issue_id, 'flake8 errors') Why not: "guide lines" ...
12 years, 4 months ago (2013-10-10 08:01:09 UTC) #7
nicoe
12 years, 4 months ago (2013-10-10 16:54:44 UTC) #8
ced
LGTM
12 years, 4 months ago (2013-10-10 17:46:18 UTC) #9
ced
11 years, 2 months ago (2014-11-27 22:49:31 UTC) #10
Can be closed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b