Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(136)

Issue 14085: Issue 774, 879, 981: DOMita style issues (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
17 years, 1 month ago by MikeSamuel
Modified:
16 years, 8 months ago
Reviewers:
metaweta
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Issue 774: Domita cross-browser style assignment A way to get and set the "float" style property - IE uses "styleFloat", others use "cssFloat", we normalize as "Dom.getStyle(element, 'float') Issue 879: Add a function to the autogenerated css-defs.js that maps between CSS property names and DOM2 Style node property names In domita.js (and domita_test.html) we use a horrible hack cssPropertyName.replace( /-([a-z])/g, function (_, ltr) { return ltr.toUpperCase(); }); to map between CSS property names (e.g. font-size, background-color) and DOM2 CSS Style Node names. Consolidate this code and extend it to handle exceptions to the rule such as float<->cssFloat (see http://beradrian.wordpress.com/tag/cssfloat/ ) Issue 981: fake style object needs getPropertyValue From http://www.w3.org/TR/DOM-Level-2-Style/css.html getPropertyValue Used to retrieve the value of a CSS property if it has been explicitly set within this declaration block.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Issue 774, 879, 981: DOMita style issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -241 lines) Patch
M src/com/google/caja/lang/css/CssPropertyPatterns.java View 4 chunks +47 lines, -4 lines 0 comments Download
M src/com/google/caja/lang/css/CssSchema.java View 5 chunks +22 lines, -9 lines 0 comments Download
M src/com/google/caja/lang/css/css21-defs.json View 1 chunk +2 lines, -1 line 0 comments Download
M src/com/google/caja/plugin/domita.js View 9 chunks +105 lines, -42 lines 0 comments Download
M tests/com/google/caja/AllTests.java View 2 chunks +1 line, -1 line 0 comments Download
A + tests/com/google/caja/lang/css/CssPropertyPatternsTest.java View 1 3 chunks +15 lines, -1 line 0 comments Download
M tests/com/google/caja/lang/css/CssSchemaTest.java View 2 chunks +11 lines, -4 lines 0 comments Download
D tests/com/google/caja/plugin/CssPropertyPatternsTest.java View 1 chunk +0 lines, -179 lines 0 comments Download
M tests/com/google/caja/plugin/domita_test_untrusted.html View 2 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 4
MikeSamuel
17 years, 1 month ago (2009-02-12 21:29:51 UTC) #1
metaweta
LGTM. http://codereview.appspot.com/14085/diff/1/3 File tests/com/google/caja/lang/css/CssPropertyPatternsTest.java (right): http://codereview.appspot.com/14085/diff/1/3#newcode131 Line 131: assertEquals("listStyleImage", CssPropertyPatterns.propertyNameToDom2Property(Name.css("list-style-image"))); I think this line breaks ...
17 years, 1 month ago (2009-02-12 23:33:07 UTC) #2
MikeSamuel
http://codereview.appspot.com/14085/diff/1/3 File tests/com/google/caja/lang/css/CssPropertyPatternsTest.java (right): http://codereview.appspot.com/14085/diff/1/3#newcode131 Line 131: assertEquals("listStyleImage", CssPropertyPatterns.propertyNameToDom2Property(Name.css("list-style-image"))); On 2009/02/12 23:33:07, metaweta wrote: > ...
17 years, 1 month ago (2009-02-12 23:47:29 UTC) #3
MikeSamuel
17 years, 1 month ago (2009-02-12 23:55:46 UTC) #4
@3246
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b