Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(682)

Issue 14074: Serverside Templates processor and Rewriter (shindig)

Can't Edit
Can't Publish+Mail
Start Review
Created:
17 years ago by levik
Modified:
11 years, 2 months ago
Reviewers:
shindig-dev, awiner
Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/
Visibility:
Public.

Description

Support for: - ${} in text nodes and attributes - loops via @repeat (some @var support) - conditionals via @if - special vars: - Top - Cur - Context.Index / Context.Count in loops Not currently supported: - Any kind of custom tags (including <os:Html> and <os:Render>) TODO: - More unit tests for TemplateProcessor

Patch Set 1 #

Total comments: 2

Patch Set 2 : added @var support, "Top" looks for top level (not parent) context #

Patch Set 3 : Incorporated EL changes from Adam, added unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+987 lines, -12 lines) Patch
common/src/main/java/org/apache/shindig/expressions/Expressions.java View 4 chunks +44 lines, -9 lines 0 comments Download
gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java View 1 2 2 chunks +7 lines, -1 line 0 comments Download
gadgets/src/main/java/org/apache/shindig/gadgets/parse/ParseModule.java View 2 chunks +2 lines, -1 line 0 comments Download
gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/MutableContent.java View 1 2 5 chunks +16 lines, -0 lines 0 comments Download
gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/PipelineDataContentRewriter.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/TemplateRewriter.java View 1 2 1 chunk +140 lines, -0 lines 0 comments Download
gadgets/src/main/java/org/apache/shindig/gadgets/spec/PipelinedData.java View 1 chunk +1 line, -0 lines 0 comments Download
gadgets/src/main/java/org/apache/shindig/templates/TemplateContext.java View 1 chunk +60 lines, -0 lines 0 comments Download
gadgets/src/main/java/org/apache/shindig/templates/TemplateELResolver.java View 1 chunk +139 lines, -0 lines 0 comments Download
gadgets/src/main/java/org/apache/shindig/templates/TemplateProcessor.java View 1 2 1 chunk +306 lines, -0 lines 0 comments Download
gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/TemplateRewriterTest.java View 1 chunk +138 lines, -0 lines 0 comments Download
gadgets/src/test/java/org/apache/shindig/templates/TemplateProcessorTest.java View 1 chunk +133 lines, -0 lines 0 comments Download

Messages

Total messages: 3
levik
http://codereview.appspot.com/14074/diff/1/6 File gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/PipelineDataContentRewriter.java (right): http://codereview.appspot.com/14074/diff/1/6#newcode198 Line 198: content.addPipelinedData(key, entry.getValue()); This is the only line I ...
17 years ago (2009-02-11 18:11:55 UTC) #1
levik
added @var support, "Top" looks for top level (not parent) context
17 years ago (2009-02-11 20:31:15 UTC) #2
levik
17 years ago (2009-02-12 23:20:47 UTC) #3
Incorporated EL changes from Adam, added unit tests
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b