Issue 140680043: Update test-scan for browser behavior changes.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 140680043: Update test-scan for browser behavior changes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by kpreid_google

Modified:
11 years, 5 months ago

Reviewers:
felix8a

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

* Chrome now has a WeakMap implementation with nothing we repair. * Firefox now allows typed array constructors to be called without 'new'. @r5695

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -23 lines)			Patch
	M	tests/com/google/caja/plugin/test-scan-guest.js	View		3 chunks	+30 lines, -23 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

felix8a

11 years, 5 months ago (2014-09-16 20:12:10 UTC) #2

lgtm

metacomment: it's been a while since I last looked at this, and it took me a
while to regain understanding of what it's doing. I don't know if this is a
problem worth fixing, and I'm not even sure what would help anyway. Just
something to keep in mind for the future.

Expand All Messages | Collapse All Messages