Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(191)

Issue 140680043: Update test-scan for browser behavior changes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by kpreid_google
Modified:
11 years, 5 months ago
Reviewers:
felix8a
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

* Chrome now has a WeakMap implementation with nothing we repair. * Firefox now allows typed array constructors to be called without 'new'. @r5695

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -23 lines) Patch
M tests/com/google/caja/plugin/test-scan-guest.js View 3 chunks +30 lines, -23 lines 0 comments Download

Messages

Total messages: 2
kpreid_google
11 years, 5 months ago (2014-09-16 17:45:12 UTC) #1
felix8a
11 years, 5 months ago (2014-09-16 20:12:10 UTC) #2
lgtm

metacomment: it's been a while since I last looked at this, and it took me a
while to regain understanding of what it's doing. I don't know if this is a
problem worth fixing, and I'm not even sure what would help anyway. Just
something to keep in mind for the future.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b