Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(201)

Issue 14061043: Fix bridal.setAttribute for <input type=> on IE 10 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by kpreid2
Modified:
12 years, 5 months ago
Reviewers:
felix8a, ihab.awad
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fixes <https://code.google.com/p/google-caja/issues/detail?id=1850>. bridal.setAttribute used setAttributeNode to work around IE 6/7 quirks, but (empirically) setAttributeNode cannot be used on IE 10 to set <input type=>, so with IE 10 (and 9, per MSDN) no longer having featureExtendedCreateElement, all such attributes are lost in ES5 mode. Therefore, only use setAttributeNode if featureExtendedCreateElement is present (even though that's technically unrelated). This is a quick fix. More correct would be to detect the specific misbehaviors which require us to use setAttributeNode. @r5608

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M src/com/google/caja/plugin/bridal.js View 1 chunk +10 lines, -6 lines 0 comments Download

Messages

Total messages: 3
kpreid2
12 years, 5 months ago (2013-09-27 20:41:31 UTC) #1
kpreid2
ping
12 years, 5 months ago (2013-10-01 20:08:08 UTC) #2
felix8a
12 years, 5 months ago (2013-10-02 03:45:14 UTC) #3
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b