Issue 14037043: http: MOE Sync: GenericUrl should handle hostname with underscore

Issue 14037043: http: MOE Sync: GenericUrl should handle hostname with underscore (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by yanivi

Modified:
11 years, 11 months ago

Reviewers:
peleyal

Base URL:
https://code.google.com/p/google-http-java-client/

Visibility:
Public.

More Reviews

Description

http: MOE Sync: GenericUrl should handle hostname with underscore

Patch Set 1 #

Total comments: 2

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -35 lines)			Patch
	M	google-http-client/src/main/java/com/google/api/client/http/GenericUrl.java	View		3 chunks	+26 lines, -7 lines	2 comments	Download
	M	google-http-client/src/test/java/com/google/api/client/http/GenericUrlTest.java	View		12 chunks	+36 lines, -28 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

peleyal

LGTM + a single comment https://codereview.appspot.com/14037043/diff/1/google-http-client/src/main/java/com/google/api/client/http/GenericUrl.java File google-http-client/src/main/java/com/google/api/client/http/GenericUrl.java (right): https://codereview.appspot.com/14037043/diff/1/google-http-client/src/main/java/com/google/api/client/http/GenericUrl.java#newcode105 google-http-client/src/main/java/com/google/api/client/http/GenericUrl.java:105: * <p>Upgrade warning: starting ...

11 years, 11 months ago (2013-09-27 13:07:23 UTC) #2

yanivi

https://codereview.appspot.com/14037043/diff/1/google-http-client/src/main/java/com/google/api/client/http/GenericUrl.java File google-http-client/src/main/java/com/google/api/client/http/GenericUrl.java (right): https://codereview.appspot.com/14037043/diff/1/google-http-client/src/main/java/com/google/api/client/http/GenericUrl.java#newcode105 google-http-client/src/main/java/com/google/api/client/http/GenericUrl.java:105: * <p>Upgrade warning: starting in version 1.18 this parses ...

11 years, 11 months ago (2013-10-01 15:40:08 UTC) #3

peleyal

11 years, 11 months ago (2013-10-01 15:42:24 UTC) #4

Right now... I really don't think it's important :)


On Tue, Oct 1, 2013 at 11:40 AM, <yanivi@google.com> wrote:

>
> https://codereview.appspot.**com/14037043/diff/1/google-**
>
http-client/src/main/java/com/**google/api/client/http/**GenericUrl.java<https://codereview.appspot.com/14037043/diff/1/google-http-client/src/main/java/com/google/api/client/http/GenericUrl.java>
> File
> google-http-client/src/main/**java/com/google/api/client/**
> http/GenericUrl.java
> (right):
>
> https://codereview.appspot.**com/14037043/diff/1/google-**
> http-client/src/main/java/com/**google/api/client/http/**
>
GenericUrl.java#newcode105<https://codereview.appspot.com/14037043/diff/1/google-http-client/src/main/java/com/google/api/client/http/GenericUrl.java#newcode105>
> google-http-client/src/main/**java/com/google/api/client/**
> http/GenericUrl.java:105:
> * <p>Upgrade warning: starting in version 1.18 this parses the
> encodedUrl using
> On 2013/09/27 13:07:23, peleyal wrote:
>
>> We should have empty line after <p>
>> Should we fix it here?
>>
>
> This changeset the source MUST match so we don't break equivalence, but
> it can be done in a separate changeset if you feel it is important.
>
>
https://codereview.appspot.**com/14037043/<https://codereview.appspot.com/140...
>

Expand All Messages | Collapse All Messages