Remove legacy tools logic

Remove legacy tools logic

This branch removes all legacy tools logic.
Simplestreams is the only way tools can be located.
There were a few consequences of this change. 
Simplestreams does not allow fake series like "series"
to be used. So the testing charm repository was changed to
be based on "quantal" since no test machine will be running
on quantal. A large number of tests were updated because of this,
but the chanes were just changing "series" to "quantal".

Another impact was on the upgrade tests. The legacy tools search
logic used to look at the public bucket if no major version match
was found. Now, if any tools are found in a location, seaching stops.
So tools located in a private bucket hide tools in a public bucket
and the tests needed to change to reflect this.

https://code.launchpad.net/~wallyworld/juju-core/remove-legacy-tools/+merge/187993

(do not edit description out of merge proposal)

[wallyworld, 2013-09-27 08:57:37]

Please take a look.

[wallyworld, 2013-09-27 13:24:59]

Please take a look.

[wallyworld, 2013-09-27 13:33:46]

Please take a look.

[fwereade, 2013-09-27 14:02:20]

I would quibble that you probably didn't need to s/series/quantal/ across the
board, but that -- and the other comments -- are as nothing before the sweeping
tide of win that is this CL. LGTM.

https://codereview.appspot.com/14031043/diff/3001/environs/manual/bootstrap.go
File environs/manual/bootstrap.go (left):

https://codereview.appspot.com/14031043/diff/3001/environs/manual/bootstrap.g...
environs/manual/bootstrap.go:108: restore :=
envtools.SetToolPrefix(envtools.NewToolPrefix)
Lovely to see these go ;).

https://codereview.appspot.com/14031043/diff/3001/environs/testing/tools.go
File environs/testing/tools.go (left):

https://codereview.appspot.com/14031043/diff/3001/environs/testing/tools.go#o...
environs/testing/tools.go:86: func RemoveFakeToolsMetadata(c *gc.C, stor
storage.Storage) {
This feels a bit more like "RemoveToolsMetadata" -- it's not like it stops if it
discovers they're real ;p.

https://codereview.appspot.com/14031043/diff/3001/environs/tools/tools_test.go
File environs/tools/tools_test.go (right):

https://codereview.appspot.com/14031043/diff/3001/environs/tools/tools_test.g...
environs/tools/tools_test.go:47: s.LoggingSuite.SetUpSuite(c)
nice

https://codereview.appspot.com/14031043/diff/3001/provider/dummy/environs.go
File provider/dummy/environs.go (left):

https://codereview.appspot.com/14031043/diff/3001/provider/dummy/environs.go#...
provider/dummy/environs.go:272: // TODO(fwereade): get rid of these.
ahhh, that's better :)