Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2503)

Issue 14028043: environs: move errors from errors package

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by rog
Modified:
10 years, 7 months ago
Reviewers:
mue, axw1, mp+187990
Visibility:
Public.

Description

environs: move errors from errors package The errors package should be reserved for errors that are widely applicable. Both "not bootstrapped" and "container not supported" are environs-specific and hence best defined there. Along the way, we change the errors to be more fit for purpose (no need for a nested error; no need for a custom message in ErrNotBootstrapped). BTW I'm not sure quite why we have a specific "containers unsupported" error, but I assume it will support some functionality as yet to arrive. https://code.launchpad.net/~rogpeppe/juju-core/423-move-errors/+merge/187990 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs: move errors from errors package #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -82 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M environs/bootstrap/bootstrap.go View 2 chunks +1 line, -2 lines 0 comments Download
A environs/errors.go View 1 chunk +38 lines, -0 lines 0 comments Download
M environs/interface.go View 2 chunks +1 line, -6 lines 0 comments Download
M environs/jujutest/livetests.go View 2 chunks +2 lines, -3 lines 0 comments Download
M environs/manual/bootstrap_test.go View 2 chunks +1 line, -3 lines 0 comments Download
M errors/errors.go View 1 chunk +0 lines, -41 lines 0 comments Download
M errors/errors_test.go View 2 chunks +0 lines, -12 lines 0 comments Download
M provider/azure/environ.go View 2 chunks +1 line, -2 lines 0 comments Download
M provider/azure/environ_test.go View 2 chunks +1 line, -2 lines 0 comments Download
M provider/ec2/ec2.go View 2 chunks +1 line, -2 lines 0 comments Download
M provider/local/environ.go View 2 chunks +1 line, -2 lines 0 comments Download
M provider/maas/environ_test.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/openstack/provider.go View 2 chunks +1 line, -2 lines 0 comments Download
M provider/state.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/state_test.go View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3
rog
Please take a look.
10 years, 7 months ago (2013-09-27 08:24:10 UTC) #1
axw1
On 2013/09/27 08:24:10, rog wrote: > Please take a look. LGTM
10 years, 7 months ago (2013-09-27 08:30:07 UTC) #2
mue
10 years, 7 months ago (2013-09-27 08:46:27 UTC) #3
LGTM, nice cleanup. Still not happy about the mix of own error types and using
of errors.New or fmt.Errorf, but that's not to be discussed here.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b