|
environs: move errors from errors package
The errors package should be reserved for errors
that are widely applicable. Both "not bootstrapped"
and "container not supported" are environs-specific
and hence best defined there.
Along the way, we change the errors to be
more fit for purpose (no need for a nested error;
no need for a custom message in ErrNotBootstrapped).
BTW I'm not sure quite why we have a specific "containers
unsupported" error, but I assume it will support
some functionality as yet to arrive.
https://code.launchpad.net/~rogpeppe/juju-core/423-move-errors/+merge/187990
(do not edit description out of merge proposal)
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+54 lines, -82 lines) |
Patch |
 |
A |
[revision details]
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
environs/bootstrap/bootstrap.go
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
A |
environs/errors.go
|
View
|
|
1 chunk |
+38 lines, -0 lines |
0 comments
|
Download
|
 |
M |
environs/interface.go
|
View
|
|
2 chunks |
+1 line, -6 lines |
0 comments
|
Download
|
 |
M |
environs/jujutest/livetests.go
|
View
|
|
2 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
 |
M |
environs/manual/bootstrap_test.go
|
View
|
|
2 chunks |
+1 line, -3 lines |
0 comments
|
Download
|
 |
M |
errors/errors.go
|
View
|
|
1 chunk |
+0 lines, -41 lines |
0 comments
|
Download
|
 |
M |
errors/errors_test.go
|
View
|
|
2 chunks |
+0 lines, -12 lines |
0 comments
|
Download
|
 |
M |
provider/azure/environ.go
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
provider/azure/environ_test.go
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
provider/ec2/ec2.go
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
provider/local/environ.go
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
provider/maas/environ_test.go
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
provider/openstack/provider.go
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
provider/state.go
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
provider/state_test.go
|
View
|
|
2 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
Total messages: 3
|