Issue 14011043: Fix tools sources for local and azure

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14011043: Fix tools sources for local and azure (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by wallyworld

Modified:
10 years, 7 months ago

Reviewers:
dave, mp+187959

Visibility:
Public.

Description

Fix tools sources for local and azure The local provider did not implement CustomToolsSources, so when it tried to get tools via simplestreams, it failed and then used the legacy fallback. But this meant that checksum and size info was missing. The azure provider did implement CustomToolsSources, but until the official tools repository comes online, the tools sources do need to include the public container from which tools can be fetched, or else simplestreams will fail and revert to legacy tools code. https://code.launchpad.net/~wallyworld/juju-core/fix-tools-sources/+merge/187959 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -2 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	provider/azure/environ.go	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	provider/azure/environ_test.go	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	provider/local/environ.go	View	3 chunks	+12 lines, -0 lines	0 comments	Download
M	provider/local/local_test.go	View	2 chunks	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

dave_cheney.net

10 years, 7 months ago (2013-09-27 00:32:03 UTC) #2

On 2013/09/27 00:28:43, wallyworld wrote:
> Please take a look.

LGTM.

Expand All Messages | Collapse All Messages