Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2929)

Issue 14006043: Fix local provider bootstrap.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by thumper
Modified:
10 years, 6 months ago
Reviewers:
mp+187955, dave, wallyworld
Visibility:
Public.

Description

Fix local provider bootstrap. The environment configuration was being serialized through JSON, which was coercing the integer values to float64. The validation schema checks were strictly looking for integers. This has now been changed to ForceInt. Test added. https://code.launchpad.net/~thumper/juju-core/fix-local-bootstrap/+merge/187955 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix local provider bootstrap. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M provider/local/environ.go View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4
thumper
Please take a look.
10 years, 7 months ago (2013-09-26 23:37:49 UTC) #1
wallyworld
LGTM
10 years, 7 months ago (2013-09-26 23:41:31 UTC) #2
thumper
Please take a look.
10 years, 6 months ago (2013-10-16 21:32:09 UTC) #3
dave_cheney.net
10 years, 6 months ago (2013-10-16 21:34:32 UTC) #4
On 2013/10/16 21:32:09, thumper wrote:
> Please take a look.

LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b