Issue 1399041: code review 1399041: Correct _cgo_free when C ABI does not pass first arg on...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1399041: code review 1399041: Correct _cgo_free when C ABI does not pass first arg on... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by iant

Modified:
14 years, 9 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

Correct _cgo_free when C ABI does not pass first arg on stack. It turns out that _cgo_malloc is used, via cmalloc in runtime/cgocall.c, which is called by code generated by out.go for the ·_C_CString function. I can't find a call to _cgo_free, but given _cgo_malloc we might as well keep _cgo_free. This patch fixes it so that it should work on amd64.

Patch Set 1 #

Patch Set 2 : code review 1399041: Correct _cgo_free when C ABI does not pass first arg on... #

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -2 lines)			Patch
	M	src/cmd/cgo/out.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/libcgo/util.c	View		2 chunks	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

iant

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 9 months ago (2010-05-29 00:52:12 UTC) #1

iant

14 years, 9 months ago (2010-05-31 05:23:01 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=f36cff25e9c8 ***

Correct _cgo_free when C ABI does not pass first arg on stack.

It turns out that _cgo_malloc is used, via cmalloc in
runtime/cgocall.c, which is called by code generated by out.go
for the ·_C_CString function.  I can't find a call to
_cgo_free, but given _cgo_malloc we might as well keep
_cgo_free.  This patch fixes it so that it should work on
amd64.

R=rsc
CC=golang-dev
http://codereview.appspot.com/1399041

Expand All Messages | Collapse All Messages